Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): rename "Created after" to "Sent out" #27570

Merged

Conversation

mareklibra
Copy link
Contributor

The "Created after" filter renamed to the "Sent out".
Based on received users' feedback, the purpose of the field seems to be more clear this way.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Based on received users' feedback, the purpose of the field seems to be
more clear this way.

Signed-off-by: Marek Libra <marek.libra@gmail.com>
@mareklibra mareklibra requested review from a team as code owners November 10, 2024 13:07
@mareklibra
Copy link
Contributor Author

sentout

@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-notifications plugins/notifications patch v0.3.3-next.1

Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that seems like a better user-facing label 👍

@mareklibra mareklibra merged commit 155a88e into backstage:master Nov 13, 2024
23 checks passed
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.33.0 release, scheduled for Tue, 19 Nov 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants