You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
sadly, I had to revert some changes; you can see this commit because some tests were failing with TypeError: theme.spacing is not a function, it can be seen here
hey @awanlin sure :) I didn't know about that RFC, though I wonder if that RFC should be mentioned in the documentation https://backstage.io/docs/tutorials/migrate-to-mui5 so that people can either migrate or wait to see what would be the decision :)
hey @awanlin sure :) I didn't know about that RFC, though I wonder if that RFC should be mentioned in the documentation https://backstage.io/docs/tutorials/migrate-to-mui5 so that people can either migrate or wait to see what would be the decision :)
No worries, I mean the RFC came after you had submitted the PR, just wanted you to be aware. Your suggestion about a link in the migration guide makes a lot of sense, can you run with that?
area:kubernetesRelated to the Kubernetes Project Area - not deploying Backstage with k8s.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
area:kubernetes
Hey, I just made a Pull Request!
Migrate the Kubernetes plugin to
mui5.The reason for using
import Grid from '@mui/material/Unstable_Grid2'is to reduce tech debt in the future, in mui 6 there is the following warning:✔️ Checklist
Signed-off-byline in the message. (more info)