-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add meta guidelines for new plugin development guides #27574
base: master
Are you sure you want to change the base?
docs: add meta guidelines for new plugin development guides #27574
Conversation
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool! Just a few comments and suggestions! But I think this is an awesome start 👏
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Co-authored-by: Peter Macdonald <macdonald.peter90@gmail.com> Signed-off-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com>
Co-authored-by: Peter Macdonald <macdonald.peter90@gmail.com> Signed-off-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and makes sense from my side!
Not sure if we want @Rugvip to take a final pass 👀
Hey, I just made a Pull Request!
Adding some light guidelines on how to write docs for the plugin development guides following #27185. The goal here is to write these, a few guides and then start asking for contributions once we have a framework that new docs can fit into.
✔️ Checklist
Signed-off-by
line in the message. (more info)