Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend filter logic to include parent group #27575

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

extend filter logic to include parent group #27575

wants to merge 9 commits into from
+94 −7

Conversation

hghtwr
Copy link
Contributor

@hghtwr hghtwr commented Nov 10, 2024 •
edited
Loading

Hey, I just made a Pull Request!

Extends the filter logic to include parent groups fetched from Gitlab for #26554

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@hghtwr
extend filter logic to include parent group
bbfd6bc 
Signed-off-by: Hghtwr <johannes.sonner@outlook.com>
@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label Nov 10, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 10, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-backend-module-gitlab plugins/catalog-backend-module-gitlab minor v0.5.0

@jhaals
Copy link
Member

jhaals commented Nov 11, 2024

Make sure to mark this as ready for review once you're done otherwise it won't be picked up by us :)

@hghtwr
add testing and root group discovery
1da0aba 
Signed-off-by: Hghtwr <johannes.sonner@outlook.com>
@hghtwr
Merge branch 'master' of github.com:hghtwr/backstage into 26554
fce9fc8
@hghtwr
add handler for encoded groups, implement test cases
66a88b1 
Signed-off-by: Hghtwr <johannes.sonner@outlook.com>
@hghtwr
use consistent group description across all tests, remove unused handler
ab92f94 
Signed-off-by: Hghtwr <johannes.sonner@outlook.com>
@hghtwr
add code comments
ad829ef 
Signed-off-by: Hghtwr <johannes.sonner@outlook.com>
@hghtwr
remove unused response object
0392ad8 
Signed-off-by: Hghtwr <johannes.sonner@outlook.com>
@hghtwr
add changeset
99dce5c 
Signed-off-by: Hghtwr <johannes.sonner@outlook.com>
@hghtwr
adopt documentation
05e1bb0 
Signed-off-by: Hghtwr <johannes.sonner@outlook.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hghtwr @jhaals