Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI consistency of Catalog filter pickers #27578

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

tylerd-canva
Copy link
Contributor

@tylerd-canva tylerd-canva commented Nov 11, 2024

Hey, I just made a Pull Request!

A few small style tweaks to make the "rest" of the filters match the Kind and Type filters at the top. It's still not perfect, note how Kind and Type have dropdowns that pop out above the page while the autocomplete-based filters reflow the content below.

Key changes:

  • remove forced uppercase picker titles and option labels
  • added theme background

Before

before screenshot

After

after screenshot

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Tyler Davis <tylerd@canva.com>
Signed-off-by: Tyler Davis <tylerd@canva.com>
@tylerd-canva tylerd-canva requested review from a team as code owners November 11, 2024 07:24
@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label Nov 11, 2024
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-react plugins/catalog-react patch v1.14.1-next.2

@jhaals jhaals merged commit be6c6ca into backstage:master Nov 12, 2024
24 checks passed
@jhaals
Copy link
Member

jhaals commented Nov 12, 2024

It does look a lot nicer, thank you!

Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.33.0 release, scheduled for Tue, 19 Nov 2024.

@jroebu14
Copy link
Contributor

Hey @tylerd-canva just making you aware of this that I hope to get merged soon! Unfortunately it overlaps with the work you did here. Hope that's OK.

@tylerd-canva
Copy link
Contributor Author

@jroebu14 Not at all! Looks like you just did a better version of what I did :) As long as the UI doesn't regress, which it doesn't seem like it does from your before/after, I'm delighted.

@tylerd-canva tylerd-canva deleted the catalog-filters-ui-consistency branch November 18, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:catalog Related to the Catalog Project Area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants