Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #27341
The time has come to remove these indices, that are lingering around for historical reasons. At this point people should have had enough time to migrate after #22594 to have that deferred index into place.
Ping @drodil and @Rugvip here too.
For reference, here follows a dump of indices on a postgres installation before the PR:
final_entities
:ON public.final_entities
USING btree (entity_ref)
final_entities_entity_id_idxCREATE INDEX final_entities_entity_id_idxON public.final_entities
USING btree (entity_id)
ON public.final_entities
USING btree (entity_id)
refresh_state
:refresh_state_entity_id_idxCREATE INDEX refresh_state_entity_id_idxON public.refresh_state
USING btree (entity_id)
refresh_state_entity_ref_idxCREATE INDEX refresh_state_entity_ref_idxON public.refresh_state
USING btree (entity_ref)
ON public.refresh_state
USING btree (entity_ref)
ON public.refresh_state
USING btree (next_stitch_at)
WHERE (next_stitch_at IS NOT NULL)
ON public.refresh_state
USING btree (next_update_at)
ON public.refresh_state
USING btree (entity_id)
search
:ON public.search
USING btree (entity_id)
search_key_idxCREATE INDEX search_key_idxON public.search
USING btree (key)
ON public.search
USING btree (key, original_value)
ON public.search
USING btree (key, value)
search_value_idxCREATE INDEX search_value_idxON public.search
USING btree (value)
refresh_state_references
:ON public.refresh_state_references
USING btree (id)
ON public.refresh_state_references
USING btree (source_entity_ref)
ON public.refresh_state_references
USING btree (source_key)
ON public.refresh_state_references
USING btree (target_entity_ref)