Improve CatalogTable title -- use label for Kinds #27590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Davis <tylerd@canva.com>
Signed-off-by: Tyler Davis <tylerd@canva.com>
Signed-off-by: Tyler Davis <tylerd@canva.com>
Changed Packages
|
tylerd-canva
changed the title
Signed-off-by: Tyler Davis <tylerd@canva.com>
|
The only problem with this as-is is how
|
Signed-off-by: Tyler Davis <tylerd@canva.com>
github-actions
bot
added
the
area:scaffolder
Signed-off-by: Tyler Davis <tylerd@canva.com>
Signed-off-by: Tyler Davis <tylerd@canva.com>
Signed-off-by: Tyler Davis <tylerd@canva.com>
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
I am not sure if it's OK to include the
CatalogTableToolbarchanges in this PR, but it seemed like a reasonable step, especially given the TODO, and also it was the easiest way to test my changes.Before
After
✔️ Checklist
Signed-off-byline in the message. (more info)