Make GitHub environment Scaffolder action use auth to resolve reviewers

[stegosaurus21]

Hey, I just made a Pull Request!

Changes the github:environment:create Scaffolder action to request and use a backend auth token when resolving the reviewer entityRefs from the Backstage catalog.

This is because previously it would throw a 401 error when backend auth was not disabled.

The logic for requesting the token is copied from the existing catalog:fetch action, which needs to do a similar thing.

Also slightly clarifies that Backstage entityRefs are expected in the reviewers list for this action.

Fixes #27515.

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• All your commits have a Signed-off-by line in the message. (more info)

[backstage-goalie]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage/plugin-scaffolder-backend-module-github	plugins/scaffolder-backend-module-github	patch	v0.5.4-next.1

[benjdlambert]

I think that you will also need to pass through the AuthService here:

backstage/plugins/scaffolder-backend-module-github/src/module.ts

Line 75 in 8ce0c4c

createGithubEnvironmentAction({

[benjdlambert]

Thanks for this! 🎉

[github-actions]

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.34.0 release, scheduled for Tue, 17 Dec 2024.

[gavinclarkeuk]

Where are the docs/examples for this change?

[benjdlambert]

@gavinclarkeuk there's no user changes required here, this is a purely internal implementation detail to call the catalog on behalf of the user that created the scaffolder job.

If you're using the new backend system there's nothing to do from an integrators point of view either as that should all be taken care of by the framework.

What are you looking for specifically?

[gavinclarkeuk]

@benjdlambert my mistake - we were seeing issues with this action, and I though it was related to the new token input parameter, but I think it may be unrelated