Make GitHub environment Scaffolder action use auth to resolve reviewers #27796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:scaffolder
Changed Packages
|
Changes the github:environment:create Scaffolder action to request and use a backend auth token when resolving the reviewer entityRefs from the Backstage catalog. This is because previously it would throw a 401 error when backend auth was not disabled. The logic for requesting the token is copied from the existing catalog:fetch action, which needs to do a similar thing. Also slightly clarifies that Backstage entityRefs are expected in the reviewers list for this action. Signed-off-by: Jason Liu <a.jason.liu21@gmail.com>
stegosaurus21
force-pushed
the
stegosaurus21/fix-create-github-env-auth
branch
from
bd8abb1 to
b5e002b
Compare
|
I think that you will also need to pass through the |
Signed-off-by: Jason Liu <a.jason.liu21@gmail.com>
stegosaurus21
force-pushed
the
stegosaurus21/fix-create-github-env-auth
branch
from
3baec71 to
2a9bd22
Compare
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Changes the github:environment:create Scaffolder action to request and use a backend auth token when resolving the reviewer entityRefs from the Backstage catalog.
This is because previously it would throw a 401 error when backend auth was not disabled.
The logic for requesting the token is copied from the existing catalog:fetch action, which needs to do a similar thing.
Also slightly clarifies that Backstage entityRefs are expected in the reviewers list for this action.
Fixes #27515.
✔️ Checklist
Signed-off-byline in the message. (more info)