Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github backend module to create-app #27983

Merged

Conversation

jescalada
Copy link
Contributor

Hey, I just made a Pull Request!

Fixes #27564, reducing friction for new users.

This prevents the nondescript Template action with ID 'publish: GitHub' is not registered from appearing for new users. In case the module is missing or was removed, the error now includes a link to the docs.

New users must still add GitHub auth integration/credentials to get the publishing to work. I edited the relevant error to link to that documentation as well.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
@jescalada jescalada requested review from a team as code owners December 4, 2024 02:55
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label Dec 4, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Dec 4, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/create-app packages/create-app patch v0.5.23-next.1
@backstage/plugin-scaffolder-backend-module-github plugins/scaffolder-backend-module-github patch v0.5.4-next.1
@backstage/plugin-scaffolder-backend plugins/scaffolder-backend patch v1.28.0-next.1

Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
Signed-off-by: Juan Escalada <juanescalada175@gmail.com>
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 thanks for this! Just a small change 🙏

.changeset/lucky-crabs-vanish.md Outdated Show resolved Hide resolved
Co-authored-by: Ben Lambert <ben@blam.sh>
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
@benjdlambert benjdlambert merged commit 71956b6 into backstage:master Dec 10, 2024
25 checks passed
@benjdlambert
Copy link
Member

Nice thanks! 🎉

Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.34.0 release, scheduled for Tue, 17 Dec 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Scaffolder actions required for demo template is not installed by create-app
3 participants