Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use an up-to-date kubernetes schema #150

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

davidfestal
Copy link
Contributor

@davidfestal davidfestal commented Nov 13, 2023

Description

In the values schema, the references to kubernetes definitions point to a rather old and obsolete schema (not updated since 3 years): https://github.com/instrumenta/kubernetes-json-schema

This PR proposes to switch to the following fork of the previous repository, which provides up-to-date kubernetes schemas: https://github.com/yannh/kubernetes-json-schema#readme

This will allow using recent Kubernetes features like Generic Ephemeral Volumes

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal force-pushed the update-the-kubernetes-schema branch from 124960a to 7348268 Compare November 13, 2023 11:36
@davidfestal davidfestal requested a review from tumido November 13, 2023 11:41
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tumido tumido merged commit 00f8d98 into backstage:main Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants