Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test) adds postgres CI tests #193

Merged
merged 5 commits into from
May 22, 2024
Merged

chore(test) adds postgres CI tests #193

merged 5 commits into from
May 22, 2024

Conversation

ChrisJBurns
Copy link
Contributor

@ChrisJBurns ChrisJBurns commented May 11, 2024

Description of the change

Adds basic postgres tests for following scenarios:

Unfortunately we cannot test for the scenario whereby you use an existing secret for the Backstage postgres user username and password because it requires a Secret already existing inside of the Cluster and we do not do this as part of our CI tests - and cannot due to limitations around ct.

Resolves: #155

Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns ChrisJBurns requested a review from a team as a code owner May 11, 2024 13:57
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns ChrisJBurns changed the title WIP: chore(test) adds basic postgres test chore(test) adds postgres CI tests May 11, 2024
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 19, 2024
@ChrisJBurns
Copy link
Contributor Author

not stale

@ChrisJBurns ChrisJBurns removed the stale label May 19, 2024
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
@vinzscam vinzscam force-pushed the adds-postgres-ci-tests branch from 2a30fcf to 36ef995 Compare May 22, 2024 11:59
@vinzscam vinzscam merged commit 62c2605 into main May 22, 2024
3 checks passed
@vinzscam vinzscam deleted the adds-postgres-ci-tests branch May 22, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for postgres scenarios where external secret is involude
2 participants