Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: notice sections for important information #225

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

Rugvip
Copy link
Member

@Rugvip Rugvip commented Oct 11, 2024

Description of the change

Just suggesting that we highlight things that I think are commonly missed

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

Just suggesting that we highlight things that I think are commonly missed

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip Rugvip requested a review from a team as a code owner October 11, 2024 13:01
@vinzscam vinzscam merged commit 978e586 into main Oct 11, 2024
1 check passed
@vinzscam vinzscam deleted the Rugvip-patch-1 branch October 11, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants