Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting Deployment replicas count via values #66

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

alexef
Copy link
Contributor

@alexef alexef commented Mar 16, 2023

Description of the change

Allow configuring the spec.replicas in the backstage deployment, for HA we need more than 1.

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@alexef alexef marked this pull request as ready for review March 16, 2023 12:03
@alexef alexef requested a review from a team as a code owner March 16, 2023 12:03
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @alexef! 🙂

I have just a small nit to the values.yaml formatting. If you don't mind, I'll also update the PR title to better describe your changes.

charts/backstage/values.yaml Show resolved Hide resolved
@tumido tumido changed the title Update values.yaml feat: allow setting Deployment replicas count via values Mar 16, 2023
@alexef
Copy link
Contributor Author

alexef commented Mar 16, 2023

oh no, I've accepted change from Github, and now DCO is mad at me again

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tumido tumido merged commit e48b18f into backstage:main Mar 20, 2023
@alexef alexef deleted the patch-1 branch March 21, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants