chore: add disclaimer about Backstage customization #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I wonder if it's worth adding a sentence about how this Chart will also not be supporting anything other than common Kubernetes and Backstage patterns? |
Member
Author
|
@ChrisJBurns what about this? 🙂 |
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
Contributor
|
lgtm |
ChrisJBurns
approved these changes
May 4, 2023
vamsi10g
pushed a commit
to vamsi10g/charts
that referenced
this pull request
May 5, 2023
Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Signed-off-by: Vamsi Gamidi <vamsi.gamidi@jobvite-inc.com>
vamsi10g
pushed a commit
to vamsi10g/charts
that referenced
this pull request
May 5, 2023
Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Signed-off-by: Vamsi Gamidi <vamsi.gamidi@jobvite-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a disclaimer about the Backstage image being deployed not being customizable/customized.
Existing or Associated Issue(s)
Resolves #67
Additional Information
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.