Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add disclaimer about Backstage customization #93

Merged
merged 1 commit into from
May 4, 2023

Conversation

tumido
Copy link
Member

@tumido tumido commented May 3, 2023

Description of the change

Adds a disclaimer about the Backstage image being deployed not being customizable/customized.

Existing or Associated Issue(s)

Resolves #67

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@tumido tumido requested a review from a team as a code owner May 3, 2023 12:49
@ChrisJBurns
Copy link
Contributor

I wonder if it's worth adding a sentence about how this Chart will also not be supporting anything other than common Kubernetes and Backstage patterns?

@tumido tumido force-pushed the add-disclaimer branch from b596bc6 to 3012064 Compare May 4, 2023 16:21
@tumido
Copy link
Member Author

tumido commented May 4, 2023

@ChrisJBurns what about this? 🙂

Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@tumido tumido force-pushed the add-disclaimer branch from 3012064 to f7322dd Compare May 4, 2023 17:00
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ChrisJBurns
Copy link
Contributor

lgtm

@tumido tumido merged commit bbd151c into backstage:main May 4, 2023
@tumido tumido deleted the add-disclaimer branch May 4, 2023 22:06
vamsi10g pushed a commit to vamsi10g/charts that referenced this pull request May 5, 2023
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
Signed-off-by: Vamsi Gamidi <vamsi.gamidi@jobvite-inc.com>
vamsi10g pushed a commit to vamsi10g/charts that referenced this pull request May 5, 2023
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
Signed-off-by: Vamsi Gamidi <vamsi.gamidi@jobvite-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make clear that people are expected to provide their own backstage image before deploying
3 participants