Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change extraEnvVarsSecrets item type to string #97

Merged
merged 1 commit into from
May 5, 2023

Conversation

vamsi10g
Copy link
Contributor

@vamsi10g vamsi10g commented May 5, 2023

changing the type of extraEnvVarsSecrets to string as providing a valid secret name as an array item is resulting in the error backstage.extraEnvVarsSecrets.0: Invalid type. Expected: object, given: string

 extraEnvVarsSecrets:
    - <secret-name>

@vamsi10g vamsi10g requested a review from a team as a code owner May 5, 2023 16:31
Signed-off-by: Vamsi Gamidi <vamsi.gamidi@jobvite-inc.com>
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!🙂

@tumido tumido merged commit 0074d5b into backstage:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants