Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazaar-backend): use the new auth system #1215

Closed
wants to merge 1 commit into from

Conversation

anicke
Copy link
Contributor

@anicke anicke commented Sep 12, 2024

Hey, I just made a Pull Request!

The bazaar-backend now uses the "new auth" system. The identity service has been removed in Backstage
making it impossible to use the bazaar without these changes.

Also did some house keeping.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@anicke anicke requested review from backstage-service and a team as code owners September 12, 2024 09:35
@anicke anicke requested a review from nickboldt September 12, 2024 09:35
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-bazaar-backend workspaces/bazaar/plugins/bazaar-backend minor v0.3.17

Signed-off-by: Niklas Aronsson <niklasar@axis.com>
@awanlin
Copy link
Contributor

awanlin commented Sep 12, 2024

Hi @anicke, given that createRouter should be removed does it make more sense to mark that as deprecated and avoid this change entirely? or is there some other way around this? Feel like double work. Ideally you should be using the New Backend System. More details here: #1176

@anicke
Copy link
Contributor Author

anicke commented Sep 12, 2024

The reason for this change is the removal of the identity service. Since there is no "coreServices.identity" any more these changes are necessary for this plugin to work using the new backend system starting with v1.31.0-next.0.

@awanlin
Copy link
Contributor

awanlin commented Sep 12, 2024

The reason for this change is the removal of the identity service. Since there is no "coreServices.identity" any more these changes are necessary for this plugin to work using the new backend system starting with v1.31.0-next.0.

I am aware of this, what I'm trying to ask is there a way we can get around this as you have been working on the code recently I was hoping you might have some ideas. If this can't be avoided then that's the way it is.

@anicke
Copy link
Contributor Author

anicke commented Sep 18, 2024

fixed by #1238

@anicke anicke closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants