Skip to content

feat(3scale): add backstage example app for 3scale #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 7, 2024
Merged

feat(3scale): add backstage example app for 3scale #1268

merged 15 commits into from
Oct 7, 2024

Conversation

@AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Sep 20, 2024 •
edited
Loading

What does this pull request do

Add backstage example app for 3scale to simplify developement.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@AndrienkoAleksandr AndrienkoAleksandr requested a review from a team as a code owner September 20, 2024 14:20
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Sep 20, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/3scale/packages/app none v0.0.0
backend workspaces/3scale/packages/backend none v0.0.0

04kash
04kash reviewed Sep 20, 2024
View reviewed changes
@04kash
Copy link
Member

04kash commented Sep 20, 2024

Thanks for this, will definitely simplify development. Just added a few comments

@nickboldt nickboldt self-requested a review September 24, 2024 15:28
@04kash 04kash mentioned this pull request Sep 24, 2024
Closed
1 task
@AndrienkoAleksandr AndrienkoAleksandr force-pushed the addExampleAppFor3ScalePlugin branch from cb4da7b to 5ed344a Compare September 26, 2024 11:06
@04kash
Copy link
Member

04kash commented Sep 26, 2024

You can remove the changeset for app and backend as we don't want these published (they are only for testing/development). Other than that looks goods!

@vinzscam vinzscam force-pushed the addExampleAppFor3ScalePlugin branch from 0406947 to 2a0638a Compare October 1, 2024 08:42
@nickboldt nickboldt enabled auto-merge (squash) October 2, 2024 14:20
@BethGriggs BethGriggs disabled auto-merge October 2, 2024 14:50
@BethGriggs
Copy link
Collaborator

BethGriggs commented Oct 2, 2024

Hey @AndrienkoAleksandr - would you mind fixing the conflicts in the yarn.lock (probably just needs a rebase and fresh yarn install). This is because we landed #1249 first

@AndrienkoAleksandr AndrienkoAleksandr force-pushed the addExampleAppFor3ScalePlugin branch from 799d4d2 to e397b32 Compare October 2, 2024 20:24
@AndrienkoAleksandr @04kash
feat(3scale): add backstage example app for 3scale
6d57eb0 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
feat(3scale): handle code review feedback
954ac19 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
feat(3scale): add changesets
defb2b7 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
feat(3scale): fix index.ts
04ab93a 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
feat(3scale): remove kubernetes frontend plugin
d6fac88 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
fix(3scale): remove permission frontend plugin
4376712 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
feat(3scale): remove tech doc plugin
28acf1b 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
feat(3scale): remove plugin-search from app
b50ed5d 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
feat(3scale): remove docker file
51be3df 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
feat(3scale): remove template
6f4d376 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
feat(3scale): remove changeset file
ea79759 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
feat(3scale): dedupe yarn.lock
d6a6fbd 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr @04kash
feat(3scale): added yarn fixes
36a9875 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@04kash 04kash force-pushed the addExampleAppFor3ScalePlugin branch from e397b32 to 36a9875 Compare October 2, 2024 20:31
@AndrienkoAleksandr
Copy link
Contributor Author

AndrienkoAleksandr commented Oct 2, 2024

Hey @AndrienkoAleksandr - would you mind fixing the conflicts in the yarn.lock

@BethGriggs done.

@nickboldt nickboldt merged commit becad19 into backstage:main Oct 7, 2024
12 checks passed
@AndrienkoAleksandr AndrienkoAleksandr mentioned this pull request Oct 22, 2024
Closed
1 task
@04kash 04kash mentioned this pull request Nov 8, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@04kash 04kash 04kash approved these changes

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/community-plugins-maintainers

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AndrienkoAleksandr @04kash @BethGriggs @nickboldt