Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(acr): add backstage app to workspace #1783

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Oct 30, 2024

Hey, I just made a Pull Request!

I added a backstage app to the acr/Azure Container Registry workspace to simplify the development process.

The workspace contains a catalog entity with the azure-container-registry/repository-name annotation.

Actually, it still requires an ACR instance and access token.

image

To solve some compile issues, I followed backstage/backstage#8694 and changed the import of useAsync from react-use.

For that change, I added a changeset.

I will raise other PRs for the planned UI improvements.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes) => No UI change in this plugin.
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Oct 30, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/acr/packages/app none v0.0.3
backend workspaces/acr/packages/backend none v0.0.0
@backstage-community/plugin-acr workspaces/acr/plugins/acr patch v1.8.6

Copy link
Contributor

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes are working as expected. Thank you.

/lgtm

@christoph-jerolimov christoph-jerolimov force-pushed the acr-add-backstage-app branch 2 times, most recently from b860cc0 to 75cce15 Compare November 18, 2024 08:48
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@schultzp2020
Copy link
Contributor

@christoph-jerolimov instead of react-use consider using @react-hookz/web instead. RE: backstage/backstage#25650

@christoph-jerolimov
Copy link
Member Author

@christoph-jerolimov instead of react-use consider using @react-hookz/web instead. RE: backstage/backstage#25650

Hey @schultzp2020, thanks, I can take look as a next step for the acr-plugin, but here I like to focus on the workspace. Can you merge that PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants