-
Notifications
You must be signed in to change notification settings - Fork 511
chore(acr): add backstage app to workspace #1783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(acr): add backstage app to workspace #1783
Conversation
Changed Packages
|
0702e4d to
9fe384b
Compare
ciiay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the changes are working as expected. Thank you.
/lgtm
75cce15 to
373db9c
Compare
|
@christoph-jerolimov instead of |
Hey @schultzp2020, thanks, I can take look as a next step for the acr-plugin, but here I like to focus on the workspace. Can you merge that PR? |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
373db9c to
fda8c5b
Compare
Hey, I just made a Pull Request!
I added a backstage app to the acr/Azure Container Registry workspace to simplify the development process.
The workspace contains a catalog entity with the
azure-container-registry/repository-nameannotation.Actually, it still requires an ACR instance and access token.
To solve some compile issues, I followed backstage/backstage#8694 and changed the import of
useAsyncfromreact-use.For that change, I added a changeset.
I will raise other PRs for the planned UI improvements.
✔️ Checklist
Signed-off-byline in the message. (more info)