Skip to content

Conversation

@christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Oct 30, 2024

Hey, I just made a Pull Request!

I added a backstage app to the acr/Azure Container Registry workspace to simplify the development process.

The workspace contains a catalog entity with the azure-container-registry/repository-name annotation.

Actually, it still requires an ACR instance and access token.

image

To solve some compile issues, I followed backstage/backstage#8694 and changed the import of useAsync from react-use.

For that change, I added a changeset.

I will raise other PRs for the planned UI improvements.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes) => No UI change in this plugin.
  • All your commits have a Signed-off-by line in the message. (more info)

@christoph-jerolimov christoph-jerolimov requested a review from a team as a code owner October 30, 2024 20:25
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Oct 30, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/acr/packages/app none v0.0.3
backend workspaces/acr/packages/backend none v0.0.0
@backstage-community/plugin-acr workspaces/acr/plugins/acr patch v1.8.7

@christoph-jerolimov christoph-jerolimov requested review from 04kash and ciiay and removed request for awanlin October 30, 2024 20:38
@christoph-jerolimov christoph-jerolimov self-assigned this Oct 30, 2024
@christoph-jerolimov christoph-jerolimov force-pushed the acr-add-backstage-app branch 4 times, most recently from 0702e4d to 9fe384b Compare October 30, 2024 22:10
Copy link
Contributor

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes are working as expected. Thank you.

/lgtm

@christoph-jerolimov christoph-jerolimov force-pushed the acr-add-backstage-app branch 3 times, most recently from 75cce15 to 373db9c Compare November 19, 2024 12:06
@schultzp2020
Copy link
Contributor

@christoph-jerolimov instead of react-use consider using @react-hookz/web instead. RE: backstage/backstage#25650

@christoph-jerolimov
Copy link
Member Author

@christoph-jerolimov instead of react-use consider using @react-hookz/web instead. RE: backstage/backstage#25650

Hey @schultzp2020, thanks, I can take look as a next step for the acr-plugin, but here I like to focus on the workspace. Can you merge that PR?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Dec 7, 2024
@github-actions github-actions bot closed this Dec 14, 2024
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@christoph-jerolimov christoph-jerolimov merged commit f9270df into backstage:main Jan 8, 2025
12 checks passed
@christoph-jerolimov christoph-jerolimov deleted the acr-add-backstage-app branch January 8, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants