Skip to content

feat(github-deployments): add support for new frontend system #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

feat(github-deployments): add support for new frontend system #1788

merged 1 commit into from
Jan 10, 2025

Conversation

craigtracey
Copy link
Contributor

Adding github-deployments support for the new frontend system.

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@craigtracey craigtracey requested review from backstage-service and a team as code owners October 31, 2024 03:11
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Oct 31, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-github-deployments workspaces/github-deployments/plugins/github-deployments patch v0.2.0

@craigtracey craigtracey force-pushed the github-deployments-fe branch from c13f760 to b0a99bf Compare October 31, 2024 05:01
@awanlin awanlin requested review from awanlin and removed request for BethGriggs November 14, 2024 22:33
@awanlin
Copy link
Contributor

awanlin commented Nov 14, 2024

Going to take on this one too 👍

awanlin
awanlin approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great contribution @craigtracey, thanks! 🚢

@awanlin
Copy link
Contributor

awanlin commented Nov 14, 2024

Ah, looks like we have API Reports to update, can you look at those please? Thanks!

@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Nov 29, 2024
@github-actions github-actions bot closed this Dec 6, 2024
@awanlin awanlin reopened this Dec 19, 2024
@github-actions github-actions bot removed the stale label Dec 19, 2024
awanlin
awanlin requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to get the API Reports updated and the CI green @craigtracey 👍

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jan 3, 2025
@github-actions github-actions bot closed this Jan 10, 2025
@awanlin awanlin reopened this Jan 10, 2025
@awanlin awanlin removed the stale label Jan 10, 2025
@craigtracey craigtracey force-pushed the github-deployments-fe branch from 8b40826 to 0e94442 Compare January 10, 2025 19:40
@craigtracey
feat(github-deployments): add support for new frontend system
26086a6 
Adding github-deployments support for the new frontend system.

Signed-off-by: Craig Tracey <craig@arctir.com>
@craigtracey craigtracey force-pushed the github-deployments-fe branch from 0e94442 to 26086a6 Compare January 10, 2025 19:44
awanlin
awanlin approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@awanlin awanlin merged commit 9063139 into backstage:main Jan 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awanlin awanlin awanlin approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigtracey @awanlin