Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linguist - Removed Deprecated Code #1804

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

awanlin
Copy link
Contributor

@awanlin awanlin commented Oct 31, 2024

Hey, I just made a Pull Request!

Removed support for what is known as the legacy backend, please use the New Backend System.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin awanlin requested a review from a team as a code owner October 31, 2024 21:35
@backstage-goalie
Copy link
Contributor

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage-community/plugin-catalog-backend-module-linguist-tags-processor

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/linguist/packages/backend none v0.0.13
@backstage-community/plugin-catalog-backend-module-linguist-tags-processor workspaces/linguist/plugins/catalog-backend-module-linguist-tags-processor none v0.2.2
@backstage-community/plugin-linguist-backend workspaces/linguist/plugins/linguist-backend minor v0.6.4

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin
Copy link
Contributor Author

awanlin commented Nov 4, 2024

Hi @BethGriggs, can you give this a quick look? Just need a sanity check, prefer not to approve and merge my own PRs.

@nickboldt nickboldt requested review from vinzscam and 04kash and removed request for BethGriggs November 5, 2024 17:26
'@backstage-community/plugin-linguist-backend': minor
---

**BREAKING** Removed support for what is known as the legacy backend, please use the New Backend System.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol @ "minor breaking" changes which are not considered major :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we ship as a major? It could make sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to keep following the conventions I've been following so far.

@awanlin awanlin enabled auto-merge (squash) November 15, 2024 23:36
@awanlin awanlin merged commit 9602620 into backstage:main Nov 15, 2024
12 checks passed
@awanlin awanlin deleted the topic/linguist-remove-deprecated-code branch November 18, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants