-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linguist - Removed Deprecated Code #1804
Linguist - Removed Deprecated Code #1804
Conversation
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
Hi @BethGriggs, can you give this a quick look? Just need a sanity check, prefer not to approve and merge my own PRs. |
'@backstage-community/plugin-linguist-backend': minor | ||
--- | ||
|
||
**BREAKING** Removed support for what is known as the legacy backend, please use the New Backend System. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol @ "minor breaking" changes which are not considered major :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not yet 1.0, I'm following this: https://github.com/backstage/backstage/blob/master/REVIEWING.md#reviewing-changeset-bump-levels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we ship as a major? It could make sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to keep following the conventions I've been following so far.
Hey, I just made a Pull Request!
Removed support for what is known as the legacy backend, please use the New Backend System.
✔️ Checklist
Signed-off-by
line in the message. (more info)