Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(redhat-argocd): remove @janus-idp/cli and dynamic plugin build step #1845

Merged
merged 1 commit into from
Nov 18, 2024
Merged

refactor(redhat-argocd): remove @janus-idp/cli and dynamic plugin build step #1845

merged 1 commit into from
Nov 18, 2024

Conversation

christoph-jerolimov
Copy link
Member

Hey, I just made a Pull Request!

This PR removes the @janus-idp/cli dependency and export-dynamic script from the 3scale workspace.

Part of

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@christoph-jerolimov christoph-jerolimov self-assigned this Nov 6, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 6, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-redhat-argocd workspaces/redhat-argocd/plugins/argocd patch v1.10.2

@christoph-jerolimov christoph-jerolimov force-pushed the remove-janus-idp-cli-from-redhat-argocd branch from b45d5d0 to 927d11a Compare November 6, 2024 09:27
@christoph-jerolimov christoph-jerolimov mentioned this pull request Nov 6, 2024
Closed
13 tasks
@christoph-jerolimov christoph-jerolimov marked this pull request as draft November 6, 2024 09:52
@christoph-jerolimov christoph-jerolimov requested review from BethGriggs and nickboldt and removed request for nickboldt November 6, 2024 09:56
@christoph-jerolimov
refactor(redhat-argocd): remove @janus-idp/cli and dynamic plugin bui…
f498419 
…ld step

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@christoph-jerolimov christoph-jerolimov force-pushed the remove-janus-idp-cli-from-redhat-argocd branch from 927d11a to f498419 Compare November 18, 2024 08:33
@christoph-jerolimov christoph-jerolimov marked this pull request as ready for review November 18, 2024 08:33
karthikjeeyar
karthikjeeyar approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the slack discussion on this topic, TAP 1.4 will continue to use RHDH bundle version of the argocd plugin and in 1.5 TAP will look at installing this plugin via container image.

/lgtm

@karthikjeeyar karthikjeeyar merged commit d1cae81 into backstage:main Nov 18, 2024
12 checks passed
@christoph-jerolimov christoph-jerolimov deleted the remove-janus-idp-cli-from-redhat-argocd branch November 19, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikjeeyar karthikjeeyar karthikjeeyar approved these changes

@awanlin awanlin Awaiting requested review from awanlin awanlin is a code owner automatically assigned from backstage/community-plugins-maintainers

@schultzp2020 schultzp2020 Awaiting requested review from schultzp2020

@BethGriggs BethGriggs Awaiting requested review from BethGriggs

@nickboldt nickboldt Awaiting requested review from nickboldt

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

Assignees

@christoph-jerolimov christoph-jerolimov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christoph-jerolimov @nickboldt @rohitkrai03 @karthikjeeyar