Migrate Azure Resource plugin #1856

kajahanne · 2024-11-06T12:44:34Z

Hey, I just made a Pull Request!

I raised this pull request to move the Azure Resources plugin from repos https://github.com/vippsas/backstage-azure-resources-backend and https://github.com/vippsas/backstage-azure-resource-frontend to the backstage/community-plugins repo so it is easy to manage, collaborate & improve with the Backstage community and standards.
This move also includes handing over ownership of this plugin to @deepan10.

✔️ Checklist

A changeset describing the change and affected packages. (more info)
Added or updated documentation
Tests for new functionality and regression tests for bug fixes
Screenshots attached (for UI changes)
All your commits have a Signed-off-by line in the message. (more info)

backstage-goalie · 2024-11-06T12:57:53Z

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

…ackstage#1826) Signed-off-by: Nowacki, Kacper <kacper.nowacki@dynatrace.com> Co-authored-by: Nick Boldt <nboldt@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Signed-off-by: Kashish Mittal <kmittal@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

…ckstage#1850) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

…namic plugin build step (backstage#1849) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

…amic plugin build step (backstage#1848) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

deepan10 · 2024-11-07T08:11:37Z

Hello @kajahanne

You have to move both frontend & backend plugin in to /workspaces/azure-resources/plugins/ directory with the default version 0.0.0 and create a changeset.

Here is reference PR #711

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

…e/community-plugins into migrate-azure-resources

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Signed-off-by: Kashish Mittal <kmittal@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

…ckstage#1850) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

…namic plugin build step (backstage#1849) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

…amic plugin build step (backstage#1848) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

…namic plugin build step (backstage#1849) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Signed-off-by: Nick Boldt <nboldt@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

…namic plugin build step (backstage#1849) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

…e/community-plugins into migrate-azure-resources

awanlin · 2024-11-13T20:51:49Z

Hi @deepan10, can you give this a review please? Once you have approved I'll give it another look over.

Hi @kajahanne, as @deepan10 will be helping own this plugin I'd like them to review it first, just wanting to keep you in the loop as to how the review process will work. 👍

deepan10 · 2024-11-16T18:53:18Z

Hello @kajahanne ,

Good to see the plugin (Frontend + Backend). It is good to migrate the backend plugin to align with the New backend system https://backstage.io/docs/backend-system/architecture/index

Also, Can you migrate packages/app and packages/backend so that it gets easier running the plugins locally?

deepan10 · 2024-11-16T18:35:05Z

workspaces/azure-resources/plugins/backstage-azure-resources-backend/src/service/router.ts

+  ClientSecretCredential,
+  DefaultAzureCredential,
+} from '@azure/identity';
+import { azureResourceConfig } from '../config';


Suggested change

import { azureResourceConfig } from '../config';

import { AzureResourceConfig } from '../config';

deepan10 · 2024-11-16T18:35:16Z

workspaces/azure-resources/plugins/backstage-azure-resources-backend/src/service/router.ts

+export async function createRouter(
+  options: RouterOptions,
+): Promise<express.Router> {
+  const azureConfig = azureResourceConfig.fromConfig(options.config);


Suggested change

const azureConfig = azureResourceConfig.fromConfig(options.config);

const azureConfig = AzureResourceConfig.fromConfig(options.config);

deepan10 · 2024-11-17T18:47:38Z

workspaces/azure-resources/plugins/backstage-azure-resources-backend/README.md

+  clientId: ab77a497-102e-4c4d-9853-3aca7e733245 # the app registrations clientId
+  clientSecret: ~AcbyiAM2YUMQwUSqhzg # a secret created for the app registration
+  tenantId: f02ae3d3-be5c-4b9d-9d6e-8192055d4083 # your Azure tenant id


Its good to mask it / use environmental variables

Suggested change

clientId: ab77a497-102e-4c4d-9853-3aca7e733245 # the app registrations clientId

clientSecret: ~AcbyiAM2YUMQwUSqhzg # a secret created for the app registration

tenantId: f02ae3d3-be5c-4b9d-9d6e-8192055d4083 # your Azure tenant id

clientId: ${AZURE_SP_ID} # the app registrations clientId

clientSecret: ${AZURE_SP_SECRET} # a secret created for the app registration

tenantId: ${AZURE_TENANT_ID} # your Azure tenant id

04kash · 2024-11-26T16:29:07Z

workspaces/azure-resources/package.json

+  "devDependencies": {
+    "@backstage/cli": "^0.28.0",
+    "@backstage/e2e-test-utils": "^0.1.1",
+    "@backstage/repo-tools": "^0.8.0",


Suggested change

"@backstage/repo-tools": "^0.8.0",

"@backstage/repo-tools": "^0.10.0",

Can you make this change so that the generated api-reports are named as report.api.md ?

kajahanne requested review from backstage-service and a team as code owners November 6, 2024 12:44

kajahanne requested a review from awanlin November 6, 2024 12:44

backstage-service and others added 9 commits November 6, 2024 14:06

Version Packages (backstage#1839)

99bfcd9

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Version Packages (backstage#1838)

f292744

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Remove unused @backstage/backend-common package from dependencies. (b…

869d684

…ackstage#1826) Signed-off-by: Nowacki, Kacper <kacper.nowacki@dynatrace.com> Co-authored-by: Nick Boldt <nboldt@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Migrate Azure Resource plugin

b99ab54

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Version Packages (backstage#1834)

8faf65c

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

plugin(keycloak): fix plugin metadata (backstage#1855)

4aea1c5

Signed-off-by: Kashish Mittal <kmittal@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

chore: add additional codeowners for acr, ocm and rbac workspaces (ba…

2000349

…ckstage#1850) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

refactor(scaffolder-relation-processor): remove @janus-idp/cli and dy…

da5aaa9

…namic plugin build step (backstage#1849) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

refactor(redhat-resource-optimization): remove @janus-idp/cli and dyn…

d62c3fe

…amic plugin build step (backstage#1848) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

kajahanne force-pushed the migrate-azure-resources branch from 7cec930 to d62c3fe Compare November 6, 2024 13:06

kajahanne requested review from 04kash, christoph-jerolimov, karthikjeeyar, schultzp2020, riginoommen, yashoswalyo and kuangp as code owners November 6, 2024 13:06

Merge branch 'main' into migrate-azure-resources

7571640

kajahanne and others added 7 commits November 11, 2024 10:52

Add plugin folders

f0ae74c

Add plugin folders

7ea1225

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Merge branch 'migrate-azure-resources' of https://github.com/kajahann…

464f885

…e/community-plugins into migrate-azure-resources

Remove plugin folders temporarily

d532998

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Version Packages (backstage#1836)

7c5d479

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Version Packages (backstage#1839)

ebd5d41

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Version Packages (backstage#1838)

3d404b0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

04kash and others added 18 commits November 11, 2024 13:22

plugin(keycloak): fix plugin metadata (backstage#1855)

94465a1

Signed-off-by: Kashish Mittal <kmittal@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

chore: add additional codeowners for acr, ocm and rbac workspaces (ba…

352b81b

…ckstage#1850) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

refactor(scaffolder-relation-processor): remove @janus-idp/cli and dy…

e38c3e5

…namic plugin build step (backstage#1849) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

refactor(redhat-resource-optimization): remove @janus-idp/cli and dyn…

9cf024b

…amic plugin build step (backstage#1848) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Version Packages (backstage#1838)

dd350e8

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

refactor(scaffolder-relation-processor): remove @janus-idp/cli and dy…

a225f61

…namic plugin build step (backstage#1849) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Update README.md - link to version-bump.md

15bcdc0

Signed-off-by: Nick Boldt <nboldt@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Add plugin folders

bfeb416

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Remove plugin folders temporarily

a03d335

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Version Packages (backstage#1838)

771f6ee

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Migrate Azure Resource plugin

2884d2c

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

refactor(scaffolder-relation-processor): remove @janus-idp/cli and dy…

6c4993e

…namic plugin build step (backstage#1849) Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Version Packages (backstage#1838)

dae17e5

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Add plugin folders

58d58b5

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Remove plugin folders temporarily

d95361f

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Add plugin folders

f167f38

Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>

Merge branch 'migrate-azure-resources' of https://github.com/kajahann…

611da5b

…e/community-plugins into migrate-azure-resources

Merge branch 'main' into migrate-azure-resources

1923932

awanlin removed request for christoph-jerolimov, riginoommen, kuangp, karthikjeeyar, yashoswalyo, schultzp2020 and 04kash November 13, 2024 20:50

deepan10 requested changes Nov 16, 2024

View reviewed changes

deepan10 requested changes Nov 17, 2024

View reviewed changes

04kash requested changes Nov 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Azure Resource plugin #1856

Migrate Azure Resource plugin #1856

kajahanne commented Nov 6, 2024 •

edited

Loading

backstage-goalie bot commented Nov 6, 2024

deepan10 commented Nov 7, 2024

awanlin commented Nov 13, 2024

deepan10 commented Nov 16, 2024

deepan10 Nov 16, 2024

deepan10 Nov 16, 2024

deepan10 Nov 17, 2024

04kash Nov 26, 2024

	import { azureResourceConfig } from '../config';
	import { AzureResourceConfig } from '../config';

	const azureConfig = azureResourceConfig.fromConfig(options.config);
	const azureConfig = AzureResourceConfig.fromConfig(options.config);

	"@backstage/repo-tools": "^0.8.0",
	"@backstage/repo-tools": "^0.10.0",

Migrate Azure Resource plugin #1856

Are you sure you want to change the base?

Migrate Azure Resource plugin #1856

Conversation

kajahanne commented Nov 6, 2024 • edited Loading

Hey, I just made a Pull Request!

✔️ Checklist

backstage-goalie bot commented Nov 6, 2024

deepan10 commented Nov 7, 2024

awanlin commented Nov 13, 2024

deepan10 commented Nov 16, 2024

deepan10 Nov 16, 2024

Choose a reason for hiding this comment

deepan10 Nov 16, 2024

Choose a reason for hiding this comment

deepan10 Nov 17, 2024

Choose a reason for hiding this comment

04kash Nov 26, 2024

Choose a reason for hiding this comment

kajahanne commented Nov 6, 2024 •

edited

Loading