plugin(quay-actions): migration of quay-actions plugin to backstage/community-plugins workspace

[Fortune-Ndlovu]

Hey, I just made a Pull Request!

The quay-actions plugin from the janus-idp/backstage-plugins repository was migrated to the community plugins, The migration was performed by following the manual migration steps outlined in the Community Plugins CONTRIBUTING guide

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• All your commits have a Signed-off-by line in the message. (more info)

[backstage-goalie]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage-community/plugin-scaffolder-backend-module-quay	workspaces/quay/plugins/quay-actions	patch	v2.2.1
@backstage-community/cli	workspaces/repo-tools/packages/cli	none	v0.0.3

[04kash]

Running yarn backstage-cli repo fix --publish from the workspace should fix the CI issue

[Fortune-Ndlovu]

Of course, yarn backstage-cli repo fix --publish will actually fix and synchronize the workspace directly while yarn backstage-cli repo fix --check --publish will only check for inconsistencies without making any changes.

[04kash]

Can you also rename the workspace to just quay instead of quay actions? We can later add other quay plugins in there as well then

[04kash]

I think you renamed the wrong directory 😅, instead of renaming workspaces/quay-actions you seemed to have renamed workspaces/quay-actions/plugins/quay-actions

[04kash]

Thanks, you'd also have to run yarn build:api-reports after this change, as the reports should be named report.api.md and not api-report.md

[Fortune-Ndlovu]

Thanks, @04kash, @awanlin!

[04kash]

looks good!

[awanlin]

Thanks for contributing this plugin @Fortune-Ndlovu, left a few easy comments.

There is one additional task that would be great to see is the in app examples. Here are the ones for the GitHub scaffolder actions: https://github.com/backstage/backstage/blob/master/plugins/scaffolder-backend-module-github/src/actions/github.examples.ts. These then show up in the app here: https://demo.backstage.io/create/actions

[04kash]

Can you also add this workspace to the CODEOWNERS file?

[backstage-goalie]

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

[Fortune-Ndlovu]

the noise came from:
➜ git rebase HEAD~25 --signoff
➜ git push --force-with-lease origin migrate-quay-actions

[04kash]

@Fortune-Ndlovu the PR seems to have some unrelated commits 🤔

[awanlin]

Thanks for the updates, spotted to small items to fix. 👍

[awanlin]

Hi @Fortune-Ndlovu, something odd has happened to this PR that seems like it may have reverted a number of your changes to address comments. Can you give it a look, please?

[schultzp2020]

Hi @Fortune-Ndlovu, something odd has happened to this PR that seems like it may have reverted a number of your changes to address comments. Can you give it a look, please?

It appears that you force-pushed without including the changes made directly in this PR through committed suggestions.

[Fortune-Ndlovu]

Rebase has made a mess on this PR, I am creating a new PR now with the relevant suggestions. Should take a few minutes, thanks.