Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example app for rbac plugins #1900

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Add example app for rbac plugins #1900

merged 6 commits into from
Nov 12, 2024

Conversation

AndrienkoAleksandr
Copy link
Contributor

Hey, I just made a Pull Request!

Add example app for rbac plugins

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@AndrienkoAleksandr
feat(rbac): add application example to test and develop rbac plugin
0568b06 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
feat(rbac): add rbac-backend plugin to app
3aa6f39 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
feat(rbac): add rbac frontent to app
38a65ba 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
fix(rbac): define permission admin - guest user
9553626 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr requested a review from a team as a code owner November 8, 2024 16:18
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/rbac/packages/app none v0.0.0
backend workspaces/rbac/packages/backend none v0.0.0

@AndrienkoAleksandr
feat(rbac): update yarn.lock
3bf1000 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@dzemanov
Copy link
Contributor

Amazing, works great!
Running yarn backstage-cli repo fix --publish can help with

The following packages are out of sync, run 'yarn fix' to fix them:
  app
  backend

@AndrienkoAleksandr
feat(rbac): fix package.json files for app and backend
0f51f9b 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
christoph-jerolimov
christoph-jerolimov approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@nickboldt nickboldt merged commit 62a7ac2 into backstage:main Nov 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt approved these changes

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@awanlin awanlin Awaiting requested review from awanlin awanlin is a code owner automatically assigned from backstage/community-plugins-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrienkoAleksandr @dzemanov @christoph-jerolimov @nickboldt