Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mend: add missing postinstall script #1902

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Mend: add missing postinstall script #1902

merged 1 commit into from
Nov 21, 2024

Conversation

vinzscam
Copy link
Member

@vinzscam vinzscam commented Nov 8, 2024

Hey, I just made a Pull Request!

Added missing postinstall script to the mend workspace.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
@vinzscam vinzscam requested a review from a team as a code owner November 8, 2024 20:21
@vinzscam vinzscam requested a review from awanlin November 8, 2024 20:21
@NormanWenzelWSS
Copy link

Hi @vinzscam, hi @awanlin , what is the timeline for merging this? Am I correct that this is the final fix before we can merge backstage/backstage#27148?

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't merge, but I can confirm that almost all workspaces has this setup.

@awanlin
Copy link
Contributor

awanlin commented Nov 14, 2024

Can't merge, but I can confirm that almost all workspaces has this setup.

We are looking at a few options around this right now before we merge this one.

@vinzscam
Copy link
Member Author

sorry @NormanWenzelWSS, I don't think this PR will help as we have an issue with releases at the moment. But #1913 will definitely help releasing your plugin.

@vinzscam vinzscam merged commit 99dcb80 into main Nov 21, 2024
13 checks passed
@vinzscam vinzscam deleted the vinzscam-patch-1 branch November 21, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants