Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for markdown 3, upgrade graphviz package #224

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Fix tests for markdown 3, upgrade graphviz package #224

merged 3 commits into from
Nov 26, 2024

Conversation

ElementalWarrior
Copy link
Contributor

  • Upgrade graphviz extension
  • assertEquals is a deprecated form of assertEqual
  • Test module does not exist, use src

@ElementalWarrior
Copy link
Contributor Author

Hi @awanlin. Any chance for a review?

@jonesbusy
Copy link
Contributor

Thanks.

This is related to #217

See also cesaremorel/markdown-inline-graphviz#13

awanlin
awanlin requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ElementalWarrior, can we trim this down, some of the changes are bine handled already in this PR #223. There also looked to be unrelated changes that crept in like the README.md

@ElementalWarrior
Copy link
Contributor Author

@awanlin I think thats just from merging the main branch into my feature branch (because a check was failing iirc).

So its github reporting things as changes that were already applied.

I can rebase it if you like. But It's effectively just re-listing already applied things.

@ElementalWarrior ElementalWarrior changed the base branch from renovate/markdown-3.x to main October 22, 2024 14:51
@ElementalWarrior
Copy link
Contributor Author

Ah, I think it was pointing at the wrong base branch to merge into.

awanlin
awanlin requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ElementalWarrior, I'd like to get in #223 first and then follow up with this one. Left a few comments in the mean time.

requirements.txt Outdated Show resolved Hide resolved
src/test_core.py Outdated Show resolved Hide resolved
src/test_core.py Outdated Show resolved Hide resolved
@awanlin
Copy link
Collaborator

awanlin commented Nov 8, 2024

Hi @ElementalWarrior, can you please rebase this? Then we can start moving it forward 👍

@ElementalWarrior
Upgrade graphviz extension
0e22069 
markdown_inline_graphviz_extension version 1.1.3 will fix markdown > 3 support.
But the version only exists in the github: https://github.com/cesaremorel/markdown-inline-graphviz
It hasn't been published to pypi yet.

See: cesaremorel/markdown-inline-graphviz#13

For now, building from github may suffice
@ElementalWarrior
Copy link
Contributor Author

@awanlin this has been rebased.

awanlin
awanlin requested changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about using a commit hash

requirements.txt Outdated Show resolved Hide resolved
@awanlin
Copy link
Collaborator

awanlin commented Nov 25, 2024

Hi @ElementalWarrior, just need an answer to this comment and then to resolve the conflict that crept in.

ElementalWarrior and others added 2 commits November 25, 2024 08:21
@ElementalWarrior @awanlin
Use commit hash instead of branch/tag name
74e7eda 
Co-authored-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
@ElementalWarrior
Merge branch 'main' into renovate/markdown-3.x
73ba890
awanlin
awanlin approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks again for the contribution and working through the various comments @ElementalWarrior, let's get this in 👍

@awanlin awanlin merged commit 6d27cab into backstage:main Nov 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awanlin awanlin awanlin approved these changes

@jonesbusy jonesbusy jonesbusy approved these changes

@deejay1 deejay1 deejay1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElementalWarrior @jonesbusy @awanlin @deejay1