Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid typography broken in WordPress 6.3 #220

Closed
bacoords opened this issue Aug 16, 2023 · 0 comments
Closed

Fluid typography broken in WordPress 6.3 #220

bacoords opened this issue Aug 16, 2023 · 0 comments

Comments

@bacoords
Copy link
Owner

We can see if this gets resolved by the time of release but a few things:

This trac ticket clearly lays out the issue of fluid type breaking in 6.3. The issue they raise is that fluid type is broken when your layout sizes in theme.json are not a pixel values. They mention clamp but in tangent we were using css variables as the values here: https://github.com/withtangent/tangent/blob/develop/src/theme-json/settings/layout.jsonc

In either case it seems to have broken it. We can determine the best fix or if even a fix is needed. I may even test with this PR in Gutenberg to see if that fixes it or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant