Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing on windows crashing #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rares-lupascu
Copy link

react-native-nearby-api@0.0.5 postinstall D:\Projects\swabit\swabit.app\node_modules\react-native-nearby-api
scripts/install.js

'scripts' is not recognized as an internal or external command,

> react-native-nearby-api@0.0.5 postinstall D:\Projects\swabit\swabit.app\node_modules\react-native-nearby-api
> scripts/install.js

'scripts' is not recognized as an internal or external command,
@hughboi
Copy link

hughboi commented Aug 15, 2018

Are you sure this fix will work on windows? If you take a look at his install.js script it is running a grep command in the doExec function, so it's still going to fail when it runs exec and tries to spawn a shell to run those UNIX commands.

@hughboi
Copy link

hughboi commented Aug 15, 2018

Also, I'm pretty sure the commands being run in the install.js file are just needed to make sure the project runs properly for iOS (in my personal project we needed those exact commands for iOS). And since you need a MAC to run iOS for react native projects, they can be completely ignored on windows in this case.

Copy link

@hughboi hughboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to my comments on the pull request.

@rares-lupascu
Copy link
Author

look inside the issues ... everyone on windows has this problem ... the path needs to start with ./ on windows ... even this would work "postinstall": "./scripts/install.js",
btw is anyone reading the issues?

@hughboi
Copy link

hughboi commented Aug 28, 2018

I was the one who wrote the not working on windows issue. Your fix of simply putting ./scripts/install.js would not work; windows won't know how to run it at all. The file starts with a UNIX she-bang that leads to where node is installed (doesn't mean anything on windows). To get this to run on windows you would have to put node scripts/install.js, but like I said this install script runs unix commands like grep, so good luck after you get it to execute. And nope, don't think this repo is active much at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants