Configure prettier and eslint-config-standard (#1123)

.eslintrc-preferred.yml

@@ -1,13 +1,22 @@
+# plugins:
+#   - "prettier"
+
+extends:
+  - "standard"
+  - "prettier"
+
+parserOptions:
+  # Override eslint-config-standard, which incorrectly sets this to "module",
+  # though that setting is only for ES6 modules, not CommonJS modules.
+  sourceType: "script"
+
 rules:
-  # From eslint-config-standard.
-  arrow-spacing: ["error", { "before": true, "after": true }]
-  brace-style: ["error", "1tbs", { "allowSingleLine": true }]
-  camelcase: ["error", { "properties": "never" }]
-  func-style: ["error", "declaration", { "allowArrowFunctions": true }]
-  indent: ["error", 2, { "SwitchCase": 1 }]
-  key-spacing: ["error", { "beforeColon": false, "afterColon": true }]
-  no-trailing-spaces: "error"
-  quotes: ["error", "single", { "avoidEscape": true, "allowTemplateLiterals": true }]
+  # prettier/prettier: "error"
+
+  # These are not disabled by eslint-config-prettier
+  spaced-comment: "off"
+  standard/object-curly-even-spacing: "off"
+  one-var: "off"
 
   # Shields additions.
   no-var: "error"

.prettierignore

@@ -0,0 +1,4 @@
+server.js
+server.spec.js
+gh-badge.js
+gh-badge.spec.js

.prettierrc.yml

@@ -0,0 +1,3 @@
+singleQuote: true
+trailingComma: es5
+bracketSpacing: true

lib/badge.js

@@ -138,6 +138,7 @@ function makeImage(data, cb) {
   try {
     result = template(data);
   } catch(e) {
+    // eslint-disable-next-line standard/no-callback-literal
     cb('', e);
     return;
   }

lib/github-provider.js

@@ -75,7 +75,7 @@ function mapGithubCommitsSince(camp, githubApiUrl, githubAuth) {
 
 //Github Release & Pre-Release Date Integration release-date-pre (?:\/(all))?
 function mapGithubReleaseDate(camp, githubApiUrl, githubAuth) {
-  camp.route(/^\/github\/(release-date|release-date-pre)\/([^\/]+)\/([^\/]+)\.(svg|png|gif|jpg|json)$/,
+  camp.route(/^\/github\/(release-date|release-date-pre)\/([^/]+)\/([^/]+)\.(svg|png|gif|jpg|json)$/,
     cache(function (data, match, sendBadge, request) {
       const releaseType = match[1]; // eg, release-date-pre / release-date
       const user = match[2];  // eg, microsoft

lib/request-handler.js

@@ -1,5 +1,6 @@
 'use strict';
 
+// eslint-disable-next-line node/no-deprecated-api
 const domain = require('domain');
 const request = require('request');
 const badge = require('./badge');

lib/suggest.js

@@ -43,8 +43,10 @@ function findSuggestions (url, cb) {
   }
   promises.push(twitterPage(url));
   Promise.all(promises).then(function(badges) {
+    // eslint-disable-next-line standard/no-callback-literal
     cb({badges: badges.filter(function(b) { return b != null; })});
   }).catch(function(err) {
+    // eslint-disable-next-line standard/no-callback-literal
     cb({badges: [], err: err});
   });
 }

package.json

@@ -70,6 +70,13 @@
     "child-process-promise": "^2.2.1",
     "dejavu-fonts-ttf": "^2.37.3",
     "eslint": "^3.18.0",
+    "eslint-config-prettier": "^2.6.0",
+    "eslint-config-standard": "^10.2.1",
+    "eslint-plugin-import": "^2.7.0",
+    "eslint-plugin-node": "^5.2.0",
+    "eslint-plugin-prettier": "^2.3.1",
+    "eslint-plugin-promise": "^3.5.0",
+    "eslint-plugin-standard": "^3.0.1",
     "glob": "^7.1.1",
     "icedfrisby": "^1.2.0",
     "icedfrisby-nock": "^1.0.0",
@@ -81,6 +88,7 @@
     "nock": "^9.0.13",
     "node-fetch": "^1.6.3",
     "opn-cli": "^3.1.0",
+    "prettier": "1.7.3",
     "read-all-stdin-sync": "^1.0.5",
     "sinon": "^2.1.0"
   },

service-tests/bower.js

@@ -4,7 +4,7 @@ const Joi = require('joi');
 const ServiceTester = require('./runner/service-tester');
 const { isVPlusDottedVersionAtLeastOne } = require('./helpers/validators');
 
-const isBowerPrereleaseVersion = Joi.string().regex(/^v\d+(\.\d+)?(\.\d+)?(\-?\w)+?$/);
+const isBowerPrereleaseVersion = Joi.string().regex(/^v\d+(\.\d+)?(\.\d+)?(-?\w)+?$/);
 
 const t = new ServiceTester({ id: 'bower', title: 'Bower' });
 module.exports = t;

service-tests/helpers/validators.js

@@ -12,7 +12,7 @@ const isStarRating = withRegex(/^[\u2605\u2606]{5}$/);
 
 const isMetric = withRegex(/^[0-9]+[kMGTPEZY]?$/);
 
-const isPercentage = withRegex(/^[0-9]+\%$/);
+const isPercentage = withRegex(/^[0-9]+%$/);
 
 const isFileSize = withRegex(/^[0-9]*[.]?[0-9]+\s(B|kB|MB|GB|TB|PB|EB|ZB|YB)$/);