Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet badges don't work for SemVer 2 packages #1044

Closed
clairernovotny opened this issue Jul 26, 2017 · 4 comments
Closed

NuGet badges don't work for SemVer 2 packages #1044

clairernovotny opened this issue Jul 26, 2017 · 4 comments
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge

Comments

@clairernovotny
Copy link

clairernovotny commented Jul 26, 2017

Might be related to use of the v3 endpoint or not (or possibly just needing to add the right semverlevel=2.0.0 query parameter), but badges for SemVer 2 packages aren't currently working.

#655

https://img.shields.io/nuget/vpre/RSAKeyVaultProvider.svg
https://www.nuget.org/packages/RSAKeyVaultProvider

See https://github.com/NuGet/Home/wiki/Semver-2.0.0-Protocol for the protocol support update. Needs an additional query parameter to return semVer 2.0 packages.

@paulmelnikow
Copy link
Member

Hi! I'm seeing nuget | v1.0.1 which matches the website, so it looks like this has been fixed. If not, feel free to reopen or comment.

@clairernovotny
Copy link
Author

That's because I released a stable package.

@clairernovotny
Copy link
Author

The key is that you have to add semVer=2.0.0 as a query string parameter to however you're getting the version list.

@kzu
Copy link
Contributor

kzu commented Aug 21, 2018

This is still not fixed, not even for stable packages, if they use semver2. See https://img.shields.io/nuget/v/InjectModuleInitializer.svg vs https://www.nuget.org/packages/InjectModuleInitializer. 2.0.0 is the latest stable, but the shield shows 1.5.0 instead, which is the last one that did not use semver2.

@paulmelnikow paulmelnikow reopened this Aug 22, 2018
@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend service-badge New or updated service badge labels Aug 22, 2018
sharwell added a commit to sharwell/shields that referenced this issue Sep 18, 2018
chris48s pushed a commit that referenced this issue Sep 20, 2018
Support NuGet packages using SemVer 2

Fixes #1044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
Development

No branches or pull requests

3 participants