Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in makeBadge/capitalize #1606

Closed
paulmelnikow opened this issue Mar 27, 2018 · 1 comment
Closed

Crash in makeBadge/capitalize #1606

paulmelnikow opened this issue Mar 27, 2018 · 1 comment
Assignees
@PyvesB
Labels
bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers sentry Bugs found using Sentry

Comments

@paulmelnikow
Copy link
Member

https://sentry.io/shields/imgshieldsio/issues/505140091/

Error: TypeError: Cannot read property 'toUpperCase' of undefined
    at capitalize (/home/m/shields/lib/make-badge.js:82:15)
    at makeBadge (/home/m/shields/lib/make-badge.js:117:15)
    at data (/home/m/shields/lib/make-badge.js:178:40)
    at /home/m/shields/server.js:8026:17
    at gotQueries (/home/m/shields/node_modules/camp/lib/camp.js:910:7)
    at getQueries (/home/m/shields/node_modules/camp/lib/camp.js:241:5)
    at catchpath (/home/m/shields/node_modules/camp/lib/camp.js:903:3)
    at Array.routeLayer (/home/m/shields/node_modules/camp/lib/camp.js:865:7)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.pathLayer (/home/m/shields/node_modules/camp/lib/camp.js:838:16)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.eventSourceLayer (/home/m/shields/node_modules/camp/lib/camp.js:617:49)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.ajaxLayer (/home/m/shields/node_modules/camp/lib/camp.js:517:39)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.wsLayer (/home/m/shields/node_modules/camp/lib/camp.js:506:50)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.genericLayer (/home/m/shields/node_modules/camp/lib/camp.js:444:5)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.monitorHandler (/home/m/shields/lib/sys/monitor.js:46:5)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at listener (/home/m/shields/node_modules/camp/lib/camp.js:401:3)
    at SecureCamp.<anonymous> (/home/m/shields/node_modules/camp/lib/camp.js:364:45)
    at SecureCamp.emit (events.js:160:13)
    at parserOnIncoming (_http_server.js:618:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:115:23)
  File "/home/m/shields/lib/make-badge.js", line 82, in capitalize
    return s[0].toUpperCase() + s.slice(1);
  File "/home/m/shields/lib/make-badge.js", line 117, in makeBadge
    text[0] = capitalize(text[0]);
  File "/home/m/shields/lib/make-badge.js", line 178, in data
    makeMakeBadgeFn: measurer => data => makeBadge(measurer, data),
  File "/home/m/shields/server.js", line 8026, in null.<anonymous>
    const svg = makeBadge(badgeData);
  File "/home/m/shields/lib/sys/monitor.js", line 46, in Array.monitorHandler
    next();
...
(58 additional frame(s) were not displayed)

Error: TypeError: Cannot read property 'toUpperCase' of undefined
    at capitalize (/home/m/shields/lib/make-badge.js:82:15)
    at makeBadge (/home/m/shields/lib/make-badge.js:117:15)
    at data (/home/m/shields/lib/make-badge.js:178:40)
    at /home/m/shields/server.js:8026:17
    at gotQueries (/home/m/shields/node_modules/camp/lib/camp.js:910:7)
    at getQueries (/home/m/shields/node_modules/camp/lib/camp.js:241:5)
    at catchpath (/home/m/shields/node_modules/camp/lib/camp.js:903:3)
    at Array.routeLayer (/home/m/shields/node_modules/camp/lib/camp.js:865:7)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.pathLayer (/home/m/shields/node_modules/camp/lib/camp.js:838:16)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.eventSourceLayer (/home/m/shields/node_modules/camp/lib/camp.js:617:49)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.ajaxLayer (/home/m/shields/node_modules/camp/lib/camp.js:517:39)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.wsLayer (/home/m/shields/node_modules/camp/lib/camp.js:506:50)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.genericLayer (/home/m/shields/node_modules/camp/lib/camp.js:444:5)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at next (/home/m/shields/node_modules/camp/lib/camp.js:408:46)
    at Array.monitorHandler (/home/m/shields/lib/sys/monitor.js:46:5)
    at bubble (/home/m/shields/node_modules/camp/lib/camp.js:407:26)
    at listener (/home/m/shields/node_modules/camp/lib/camp.js:401:3)
    at SecureCamp.<anonymous> (/home/m/shields/node_modules/camp/lib/camp.js:364:45)
    at SecureCamp.emit (events.js:160:13)
    at parserOnIncoming (_http_server.js:618:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:115:23)
@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend sentry Bugs found using Sentry labels Mar 27, 2018
@paulmelnikow paulmelnikow changed the title TypeError: Cannot read property 'toUpperCase' of undefined Crash in capitalize Mar 27, 2018
@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Mar 27, 2018
@paulmelnikow paulmelnikow changed the title Crash in capitalize Crash in makeBadge/capitalize Mar 27, 2018
@PyvesB PyvesB self-assigned this Mar 30, 2018
@PyvesB PyvesB mentioned this issue Mar 30, 2018
Merged
@PyvesB
Copy link
Member

PyvesB commented Apr 1, 2018

Related pull request merged, closing.

@PyvesB PyvesB closed this as completed Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PyvesB PyvesB

Labels
bug Bugs in badges and the frontend core Server, BaseService, GitHub auth, Shared helpers sentry Bugs found using Sentry
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmelnikow @PyvesB