Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debounce badge updates from badge customizer #3092

Closed
paulmelnikow opened this issue Feb 24, 2019 · 2 comments
Closed

Debounce badge updates from badge customizer #3092

paulmelnikow opened this issue Feb 24, 2019 · 2 comments
Labels
frontend The Docusaurus app serving the docs site performance-improvement Related to performance or throughput of the badge servers

Comments

@paulmelnikow
Copy link
Member

Doing some testing for #2068 I noticed a single use of the badge customizer triggered about 10 badge requests.

Probably it would be good idea to throttle or debounce them! Maybe we could wait for the output to stabilize for about 250-500 ms before firing the request, sort of like how we handle the search.
@paulmelnikow paulmelnikow added frontend The Docusaurus app serving the docs site performance-improvement Related to performance or throughput of the badge servers labels Feb 24, 2019
@RedSparr0w
Copy link
Member

Sounds like a good idea, the timing for the search seems reasonable, without feeling sluggish.

@chris48s
Copy link
Member

We have just launched a completely redesigned frontend https://shields.io/
Closing this issue as it relates to the previous frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend The Docusaurus app serving the docs site performance-improvement Related to performance or throughput of the badge servers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulmelnikow @chris48s @RedSparr0w