Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change server module to ESM from CommonJS #6528

Closed
calebcartwright opened this issue May 21, 2021 · 3 comments · Fixed by #6651
Closed

Change server module to ESM from CommonJS #6528

calebcartwright opened this issue May 21, 2021 · 3 comments · Fixed by #6651
Assignees
Labels
blocker PRs and epics which block other work core Server, BaseService, GitHub auth, Shared helpers

Comments

@calebcartwright
Copy link
Member

Several core dependencies within our tree have cut over from CommonJS to ESM which is blocking updates (#6419).

This was discussed at the last ops meeting and consensus seems to be that we'll need to completely move the server over to ESM sooner rather than later

@calebcartwright calebcartwright added blocker PRs and epics which block other work core Server, BaseService, GitHub auth, Shared helpers labels May 21, 2021
@PyvesB PyvesB self-assigned this May 22, 2021
@PyvesB
Copy link
Member

PyvesB commented May 22, 2021

Have started looking into this in a bit more details. Not sure how far I'll get, but hopefully I'll have something to share soon-ish.

@paulmelnikow
Copy link
Member

🚀 🎉

@chris48s
Copy link
Member

chris48s commented Jul 9, 2021

Now that the CommonJS to ESM migration is done there is a follow up job of upgrading the dependencies we have been ignoring. Do we have a list of what dependency upgrades this unblocks aside from escape-string-regexp ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker PRs and epics which block other work core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants