change closed GitHub issue color to purple, run [GitHubIssueDetail] #7374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chris48s
reviewed
Dec 16, 2021
services/github/github-helpers.js
Outdated
| @@ -11,7 +11,7 @@ const documentation = ` | |||
| ` | |||
|
|
|||
| function stateColor(s) { | |||
| return { open: '2cbe4e', closed: 'cb2431', merged: '6f42c1' }[s] | |||
| return { open: '2cbe4e', closed: '6f42c1', merged: '6f42c1' }[s] | |||
There was a problem hiding this comment.
A closed (but not merged) PR is still presented as red. I think we need to split this into 2 functions
function issueStateColor(s) {
return { open: '2cbe4e', closed: '6f42c1' }[s]
}
function pullRequestStateColor(s) {
return { open: '2cbe4e', closed: 'cb2431', merged: '6f42c1' }[s]
}Edit: Scratch that. I have just properly read the top post 🤦
Given this isn't used for PRs, do we need merged here?
There was a problem hiding this comment.
good point, will update
calebcartwright
force-pushed
the
gh-purple-closed-issues
branch
from
49f49f1
to
f016766
Compare
chris48s
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7372
We handle the coloring of non-open PRs directly within the service's render function, so this change will only apply to closed issues