Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update svgo to the latest version 🚀 #1473

Merged
merged 13 commits into from
Apr 2, 2018
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jan 30, 2018

Version 1.0.4 of svgo was just published.

Dependency svgo
Current Version 0.7.2
Type dependency

The version 1.0.4 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of svgo.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 98 commits.

  • c47c71b v1.0.4
  • b6274f2 Bump dependencies
  • 1a3c32b Fix error due to invalid transform. Close #846
  • b182569 Fixes #218
  • 54de6f7 Correct check for switch
  • eb3b4b8 Prevent removing groups that are direct child of "". Fix #845
  • a6d2c88 v1.0.3
  • f067ea9 Fix removeViewBox to check for zero start coordinates. Fixes #832
  • efcb07e Avoid extra trailing whitespace in stdout mode
  • 7797bba Do not print statistics when using in stdout mode
  • 3ec0767 v1.0.2
  • ceccf1f Fix inlineStyles working on foreignObject content. Fixes #823
  • f03d832 Update readme to sync with actual state
  • e25cf30 Add tests and fix for onlyMatchedOnce option cleaning classes/IDs that matched more than once.
  • 00ca73b v1.0.1

There are 98 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@shields-ci
Copy link

shields-ci commented Jan 30, 2018

Warnings
⚠️

This PR modified helper functions in lib/ but not accompanying tests. That's okay so long as it's refactoring existing code.

Messages
📖

✨ Thanks for your contribution to Shields, @Greenkeeper[bot]!

Generated by 🚫 dangerJS

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Feb 26, 2018

Version 1.0.5 just got published.

Update to this version instead 🚀

Commits

The new version differs by 9 commits.

  • cd36e14 v1.0.5
  • 4dbd257 Merge pull request #908 from harrisjose/master
  • 40987c9 Fix issue with prefixIDs plugin not replacing url() values correctly
  • 2ce1066 Add failing test case for prefixIDs plugin
  • 6a9bc56 Clarify how to enable/disable multiple plugins (#904)
  • e0a8367 Fix enable-background attribute
  • 36213a8 inkscape-svgo
  • 981328e Merge pull request #902 from bnjmn-jns/patch-1
  • 3ec6cef Added config example to node example file

See the full diff

@paulmelnikow
Copy link
Member

Needs some careful tests to make sure the badges still work. Ideally I'd like to write a snapshot test that confirms the SVG is the same before or after. Though a manual test would also be just fine.

@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Mar 4, 2018
@paulmelnikow
Copy link
Member

Will update and land this after #1557.

@paulmelnikow paulmelnikow force-pushed the greenkeeper/svgo-1.0.4 branch from 895e282 to 1d3f8ad Compare March 12, 2018 01:04
@paulmelnikow
Copy link
Member

Okay, with the check from #1557 merged tests are failing: https://circleci.com/gh/badges/shields/3289

It looks like the updated svgo is not doing anything at all! So this needs a bit of work. Maybe an integration issue.

@paulmelnikow paulmelnikow requested a review from RedSparr0w March 19, 2018 12:20
@paulmelnikow paulmelnikow requested a review from platan March 28, 2018 00:20
@paulmelnikow
Copy link
Member

Self-reviewed: 👍

@paulmelnikow paulmelnikow merged commit 724abd0 into master Apr 2, 2018
@paulmelnikow paulmelnikow deleted the greenkeeper/svgo-1.0.4 branch April 2, 2018 02:57
@paulmelnikow paulmelnikow added the dependencies Related to dependency updates label Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth, Shared helpers dependencies Related to dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants