Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microbadger] Fix tests #1600

Merged
merged 1 commit into from
Mar 27, 2018
Merged

[microbadger] Fix tests #1600

merged 1 commit into from
Mar 27, 2018

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Mar 25, 2018

This pull request should fix the failing MicroBadger tests reported in #1591 (image size without a specified tag and image size without a specified tag and no download size data returned). If they start failing again in the near future, I suggest we rethink our testing strategy for this service (perhaps looser validation?), but for now, let's give it another try!

@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @PyvesB!

📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS

@PyvesB PyvesB added the service-badge New or updated service badge label Mar 25, 2018
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a plan

@PyvesB PyvesB merged commit ed419b0 into badges:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants