Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Twitter suggestion if URL does not have protocol #1604

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

espadrine
Copy link
Member

This resolves the following error occurring in production:

TypeError: Cannot read property 'slice' of null
/home/m/shields/lib/suggest.js in twitterPage at line 63:31
  const schema = url.protocol.slice(0, -1);

This resolves the following error occurring in production:

```
TypeError: Cannot read property 'slice' of null
/home/m/shields/lib/suggest.js in twitterPage at line 63:31
  const schema = url.protocol.slice(0, -1);
```
@espadrine espadrine added the bug Bugs in badges and the frontend label Mar 26, 2018
@espadrine espadrine requested a review from paulmelnikow March 26, 2018 22:29
@shields-ci
Copy link

Warnings
⚠️

This PR modified helper functions in lib/ but not accompanying tests. That's okay so long as it's refactoring existing code.

Messages
📖

✨ Thanks for your contribution to Shields, @espadrine!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow merged commit 17ddd18 into badges:master Mar 26, 2018
@paulmelnikow paulmelnikow added the sentry Bugs found using Sentry label Mar 27, 2018
@paulmelnikow
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend sentry Bugs found using Sentry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants