-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump eslint-plugin-react from 7.11.1 to 7.12.0 #2609
Merged
paulmelnikow
merged 6 commits into
master
from
dependabot/npm_and_yarn/eslint-plugin-react-7.12.0
Jan 2, 2019
Merged
Bump eslint-plugin-react from 7.11.1 to 7.12.0 #2609
paulmelnikow
merged 6 commits into
master
from
dependabot/npm_and_yarn/eslint-plugin-react-7.12.0
Jan 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.11.1 to 7.12.0. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.11.1...v7.12.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
paulmelnikow
reviewed
Jan 1, 2019
frontend/components/markup-modal.js
Outdated
@@ -80,6 +80,8 @@ export default class MarkupModal extends React.Component { | |||
let urlsForProps, link | |||
if (props.example) { | |||
urlsForProps = MarkupModal.urlsForProps(props) | |||
// https://github.com/yannickcr/eslint-plugin-react/issues/2101 | |||
// eslint-disable-next-line react/prop-types | |||
link = props.example.example.link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is triggering a false positive:
/Users/pnm/code/shields/frontend/components/markup-modal.js
85:36 error 'link' is missing in props validation react/prop-types
paulmelnikow
previously approved these changes
Jan 1, 2019
paulmelnikow
approved these changes
Jan 2, 2019
dependabot-preview
bot
deleted the
dependabot/npm_and_yarn/eslint-plugin-react-7.12.0
branch
January 2, 2019 02:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps eslint-plugin-react from 7.11.1 to 7.12.0.
Release notes
Sourced from eslint-plugin-react's releases.
Changelog
Sourced from eslint-plugin-react's changelog.
Commits
a83d65c
Update CHANGELOG and bump version0c6160e
[Dev Deps] updatecoveralls
,babel-eslint
,typescript
cd6c8e6
[Deps] updateresolve
d2b5b73
Merge pull request #1828 from alexzherdev/1721-no-typos-create-classe747459
[Tests] remove node 5/7/9, add node 11b33ae84
Merge pull request #1098 from arian/createElement-display-test84be80a
Merge pull request #1824 from alexzherdev/1762-jsx-max-depth-false-positivea442067
Merge pull request #2029 from sstern6/issue14227d07c37
Merge pull request #2032 from alexzherdev/jsx-fragments-message8c6a8e2
Merge pull request #2089 from jomasti/feature/support-react-forwardref-memoDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge@dependabot reopen
will reopen this PR if it is closed@dependabot ignore this [patch|minor|major] version
will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard:
Finally, you can contact us by mentioning @dependabot.