Adds actual build status from docker hub as discussed in issue #241 #856

eddiewebb · 2017-01-14T13:53:41Z

Building on @jrottenberg 's contribution, but adding actual status for latest build to address discussion in issue #241

I debated just leaving the language to duplicate "Docker Automated Build" and let's folks choose. BUt ultimately decided to use "Docker Build Status" instead, I'd use it either way.

jrottenberg · 2017-01-14T16:23:15Z

Oh ! Very nice

eddiewebb · 2017-03-02T17:10:08Z

@espadrine - anything I can do to help address the backlog of pull requests?

Bekt · 2017-04-05T21:24:02Z

Anything holding this?

paulmelnikow · 2017-04-05T21:46:39Z

server.js

+        badgeData.text[1] = 'failing';
+        badgeData.colorscheme = 'red';
+      } else {
+        badgeData.text[1] = 'building..';


Could you change this to 'building', for consistency with the appearance of other badges at https://shields.io/?

paulmelnikow · 2017-04-05T21:48:29Z

server.js

+    try {
+      var data = JSON.parse(buffer);
+      var latest_status = data.results[0].status;
+      if ( latest_status == 10 ) {


Can you remove the spacing in this if? Most of the code looks that way today, though we don't have that linter rule turned on just yet.

paulmelnikow · 2017-04-05T21:48:59Z

server.js

+        badgeData.colorscheme = 'red';
+      } else {
+        badgeData.text[1] = 'building..';
+        badgeData.colorB = '#008bb8';


I like that color!

paulmelnikow · 2017-04-05T21:51:01Z

server.js

+  }
+  var path = user + '/' + repo;
+  var url = 'https://registry.hub.docker.com/v2/repositories/' + path + '/buildhistory';
+  var badgeData = getBadgeData('docker status', data);


'docker build' seems like a clearer label, which would be more consistent with the other CI badges.

paulmelnikow · 2017-04-05T21:51:59Z

server.js

@@ -4960,6 +4960,45 @@ cache(function(data, match, sendBadge, request) {
  });
 }));

+// Docker Hub automated integration, latest status (passed, pending, failed)
+camp.route(/^\/docker\/status\/([^\/]+)\/([^\/]+)\.(svg|png|gif|jpg|json)$/,


How about using docker/build for this instead of docker/status?

paulmelnikow · 2017-04-05T21:53:38Z

Hi, thanks for this contribution! Would love to get this merged. Left a handful of minor comments. If you could also merge master into the PR branch, you can check that the automated tests are passing.

paulmelnikow · 2017-04-05T21:55:48Z

@eddiewebb I just saw your note above! Would be great to have some more help with the project. 😄

Would you be interested in working on some automated tests?

eddiewebb · 2017-04-05T22:53:01Z

I thought docker/build conflicts with the existing shield (which just indicates whether it exists, not health). But I can confirm and make the other changes.

If it does conflict, would you rather replace or use a different path?

paulmelnikow · 2017-04-05T23:11:48Z

The current badge is at /docker/automated. You can type in "docker" at the top of https://shields.io/ to filter the listing, which is up to date with what's in server.js.

eddiewebb · 2017-04-05T23:12:55Z

Beauty. You'll see updates shortly

eddiewebb · 2017-04-06T13:08:37Z

Sorry, didn't get to it last night, but made the changes you suggested and merged in latest from the upstream's master branch.

…ted url in try.html

eddiewebb · 2017-04-06T13:44:23Z

New labels:

Added 404 message for invalid user or repo:

paulmelnikow · 2017-04-06T14:33:50Z

Those error badges look a little busy, how about just 'repo not found'?

This is looking great. I'll test on my machine and then should be good to go.

eddiewebb · 2017-04-06T15:16:52Z

new look for your review:

paulmelnikow · 2017-04-06T15:31:03Z

Love it! All looks good. Last step is to test this myself, which might take a day or two.

paulmelnikow · 2017-04-07T03:40:39Z

Cool, ran this and it looks good.

This is a documentation nit. From looking at https://hub.docker.com/r/jrottenberg/ffmpeg/builds/, it seems like "latest" has a special meaning on Docker Hub. Is that correct? If so, would it be better to avoid the word "latest" in the code and documentation here, and instead say something like "most recent"?

eddiewebb · 2017-04-07T11:59:40Z

@paulmelnikow, it is a convention many use to Tag the most recent stable build as "LATEST".

I'll update the code and comments to be most_recent to eliminate any ambiguity.

…gging convention

paulmelnikow · 2017-04-07T12:08:11Z

Thanks! Appreciate your responsiveness.

niccokunzmann · 2017-04-07T13:59:19Z

Should index.html also be changed andcommitted? make website should be the command to do that.
When will the changes go live?
referring to "unbounded api calls" I can create an issue for tags. Let's discuss it there.

@paulmelnikow What do you think?

paulmelnikow · 2017-04-07T14:05:59Z

index.html: I'd prefer we just update and commit it at deploy time. It makes PRs easier to read, avoids unnecessary merge conflicts, is fewer steps for contributors, and makes it less likely contributors will accidentally update index.html instead of try.html.

I'd like to update the deploy script to do that, feel free to open an issue if you'd like to track it.

The changes will go live when Thaddée next deploys the server. How's that for a tautology?

niccokunzmann · 2017-04-07T14:34:42Z

@paulmelnikow I created two issues for discussion and checked all questions as answered. Thanks!

nwhobart · 2017-04-07T15:00:02Z

@paulmelnikow @eddiewebb really been looking forward to this. thanks! even though it's been merged in is there a reason it's not showing up on the homepage?

forgive me if i'm missing something obvious.

niccokunzmann · 2017-04-07T16:07:35Z

@hobakill

The changes will go live when Thaddée next deploys the server.

source

It is not an automated deploy but you can create an issue for that.

paulmelnikow · 2017-04-07T16:49:36Z

I'm glad everyone is so excited about it! I'll post a note here once it happens.

espadrine · 2017-04-12T21:44:29Z

🚀 Deployed.

sinedied · 2017-12-27T20:15:28Z

=> works fine
=> not found

Same repo. Am I missing something?

paulmelnikow · 2017-12-27T20:21:03Z

Could you open a new issue, please?

sinedied · 2017-12-27T20:26:15Z

Sure, will do.

mosesliao · 2018-06-23T13:20:02Z

what is the markdown code to implement these docker badge?

RedSparr0w · 2018-06-24T22:30:23Z

@liaogz82:
![Docker Badge](https://img.shields.io/docker/<type>/<user>/<repo>.svg)
Replace <type>, <user>, <repo> with your own values, eg:

![Docker Stars](https://img.shields.io/docker/stars/jrottenberg/ffmpeg.svg)
![Docker Pulls](https://img.shields.io/docker/pulls/jrottenberg/ffmpeg.svg)
![Docker Automated](https://img.shields.io/docker/automated/jrottenberg/ffmpeg.svg)
![Docker Build](https://img.shields.io/docker/build/jrottenberg/ffmpeg.svg)

mosesliao · 2018-06-25T08:30:06Z

Not working. It says error fetching resources

…

On Mon, Jun 25, 2018 at 6:30 AM, Danial ***@***.***> wrote: @liaogz82 <https://github.com/liaogz82>: ![Docker Badge](https://img.shields.io/docker/<type>/<user>/<repo>.svg) Replace <type>, <user>, <repo> with your own values, eg: ![Docker Stars](https://img.shields.io/docker/stars/jrottenberg/ffmpeg.svg) ![Docker Pulls](https://img.shields.io/docker/pulls/jrottenberg/ffmpeg.svg) ![Docker Automated](https://img.shields.io/docker/automated/jrottenberg/ffmpeg.svg) ![Docker Build](https://img.shields.io/docker/build/jrottenberg/ffmpeg.svg) [image: Docker Stars] <https://camo.githubusercontent.com/e26be5a5a0585294bc9281de1dc6868218f17065/68747470733a2f2f696d672e736869656c64732e696f2f646f636b65722f73746172732f6a726f7474656e626572672f66666d7065672e737667> [image: Docker Pulls] <https://camo.githubusercontent.com/8bb1c09dbae0d17b9e127b9b7616ddd18e9355b2/68747470733a2f2f696d672e736869656c64732e696f2f646f636b65722f70756c6c732f6a726f7474656e626572672f66666d7065672e737667> [image: Docker Automated] <https://camo.githubusercontent.com/c860f054353d1e72b7a74d4cc3807ba2c982c980/68747470733a2f2f696d672e736869656c64732e696f2f646f636b65722f6175746f6d617465642f6a726f7474656e626572672f66666d7065672e737667> [image: Docker Build] <https://camo.githubusercontent.com/53372b27b2001a8613d1c8a8def7c660074aea06/68747470733a2f2f696d672e736869656c64732e696f2f646f636b65722f6275696c642f6a726f7474656e626572672f66666d7065672e737667> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#856 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AATWa6TJ6R7nYSqUJwemS8_3KHQB00YAks5uABMCgaJpZM4LjoWJ> .

eddiewebb · 2018-06-25T13:07:35Z

Please open an issue.

thiagospassos · 2019-01-26T06:42:00Z

For me it shows manual even though it's automated

paulmelnikow · 2019-01-26T16:00:45Z

Hi! This PR is two years old. Could you please open a new issue?

eddiewebb added 2 commits January 14, 2017 08:47

Adds actual build status from docker hub as discussedin issue badges#241

70fb19b

issue badges#241 changed tense to present to match other shields

65bf201

ivg mentioned this pull request Jan 17, 2017

Docker CI builds the released version BinaryAnalysisPlatform/bap#607

Closed

paulmelnikow added the service-badge New or updated service badge label Mar 27, 2017

paulmelnikow requested changes Apr 5, 2017

View reviewed changes

eddiewebb mentioned this pull request Apr 6, 2017

Add Dockerhub automated build integration #866 #888

Closed

eddiewebb added 2 commits April 6, 2017 09:03

updates from @paulmelnikow feedback on badges#856

8dc175d

Merge remote-tracking branch 'upstream/master' into issue-241

423b208

added 404 check before parsing info(enhancement from badges#888, upda…

ba6baae

…ted url in try.html

less busy 404

afcf5e6

paulmelnikow approved these changes Apr 6, 2017

View reviewed changes

renamed latest_ to most_recent_ to avoid confusion with docker hub ta…

ad4e7e2

…gging convention

paulmelnikow merged commit b791ffd into badges:master Apr 7, 2017

paulmelnikow mentioned this pull request Apr 7, 2017

Docker Hub Automated Build Status #241

Closed

This was referenced Apr 7, 2017

Badge request: Dockerhub build status for tags #935

Open

Do not commit the index.html file. #936

Closed

eddiewebb added a commit to eddiewebb/shields that referenced this pull request Nov 14, 2018

updates from @paulmelnikow feedback on badges#856

9f2715c

badges locked as resolved and limited conversation to collaborators Jan 26, 2019

Adds actual build status from docker hub as discussed in issue #241 #856

Adds actual build status from docker hub as discussed in issue #241 #856

Conversation

eddiewebb commented Jan 14, 2017 • edited Loading

jrottenberg commented Jan 14, 2017

eddiewebb commented Mar 2, 2017

Bekt commented Apr 5, 2017

paulmelnikow Apr 5, 2017

Choose a reason for hiding this comment

paulmelnikow Apr 5, 2017

Choose a reason for hiding this comment

paulmelnikow Apr 5, 2017

Choose a reason for hiding this comment

paulmelnikow Apr 5, 2017

Choose a reason for hiding this comment

paulmelnikow Apr 5, 2017

Choose a reason for hiding this comment

paulmelnikow commented Apr 5, 2017

paulmelnikow commented Apr 5, 2017

eddiewebb commented Apr 5, 2017

paulmelnikow commented Apr 5, 2017

eddiewebb commented Apr 5, 2017

eddiewebb commented Apr 6, 2017

eddiewebb commented Apr 6, 2017 • edited Loading

paulmelnikow commented Apr 6, 2017

eddiewebb commented Apr 6, 2017

paulmelnikow commented Apr 6, 2017

paulmelnikow commented Apr 7, 2017

eddiewebb commented Apr 7, 2017

paulmelnikow commented Apr 7, 2017

niccokunzmann commented Apr 7, 2017 • edited Loading

paulmelnikow commented Apr 7, 2017

niccokunzmann commented Apr 7, 2017

nwhobart commented Apr 7, 2017

niccokunzmann commented Apr 7, 2017 • edited Loading

paulmelnikow commented Apr 7, 2017

espadrine commented Apr 12, 2017

sinedied commented Dec 27, 2017 • edited Loading

paulmelnikow commented Dec 27, 2017

sinedied commented Dec 27, 2017

mosesliao commented Jun 23, 2018

RedSparr0w commented Jun 24, 2018

mosesliao commented Jun 25, 2018 via email

eddiewebb commented Jun 25, 2018

thiagospassos commented Jan 26, 2019 • edited Loading

paulmelnikow commented Jan 26, 2019

eddiewebb commented Jan 14, 2017 •

edited

Loading

eddiewebb commented Apr 6, 2017 •

edited

Loading

niccokunzmann commented Apr 7, 2017 •

edited

Loading

niccokunzmann commented Apr 7, 2017 •

edited

Loading

sinedied commented Dec 27, 2017 •

edited

Loading

thiagospassos commented Jan 26, 2019 •

edited

Loading