From 9e5d7d22f2404dd5d12da0ed803895484d55513b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Venturo?= <nicolas.venturo@gmail.com> Date: Wed, 23 Mar 2022 18:25:35 -0300 Subject: [PATCH] Misc fixes on LM system (#1196) * Remove misleading comments Co-authored-by: Tom French <tom@tomfren.ch> --- pkg/liquidity-mining/contracts/AuthorizerAdaptor.sol | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/pkg/liquidity-mining/contracts/AuthorizerAdaptor.sol b/pkg/liquidity-mining/contracts/AuthorizerAdaptor.sol index a9d42afd69..59a06b1045 100644 --- a/pkg/liquidity-mining/contracts/AuthorizerAdaptor.sol +++ b/pkg/liquidity-mining/contracts/AuthorizerAdaptor.sol @@ -69,7 +69,7 @@ contract AuthorizerAdaptor is IAuthorizerAdaptor, ReentrancyGuard { /** * @notice Returns the action ID associated with calling a given function through this adaptor - * @dev The contracts managed by this adaptor do not have action ID disambiguators we use the adaptor's globally + * @dev As the contracts managed by this adaptor don't have action ID disambiguators, we use the adaptor's globally. * This means that contracts with the same function selector will have a matching action ID: * if granularity is required then permissions must not be granted globally in the Authorizer. * @@ -77,9 +77,6 @@ contract AuthorizerAdaptor is IAuthorizerAdaptor, ReentrancyGuard { * @return The associated action ID */ function getActionId(bytes4 selector) public view override returns (bytes32) { - // Each external function is dynamically assigned an action identifier as the hash of the disambiguator and the - // function selector. Disambiguation is necessary to avoid potential collisions in the function selectors of - // multiple contracts. return keccak256(abi.encodePacked(_actionIdDisambiguator, selector)); }