From dc62600f02fa4120bdc409ee32e26f1f134c2bc1 Mon Sep 17 00:00:00 2001 From: Gery Hirschfeld Date: Thu, 23 May 2024 15:44:22 +0200 Subject: [PATCH] chore: improve function name --- .../components/bal-number-input/bal-number-input.utils.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/core/src/components/bal-number-input/bal-number-input.utils.ts b/packages/core/src/components/bal-number-input/bal-number-input.utils.ts index 2dda0b998..d35ce7451 100644 --- a/packages/core/src/components/bal-number-input/bal-number-input.utils.ts +++ b/packages/core/src/components/bal-number-input/bal-number-input.utils.ts @@ -3,6 +3,10 @@ import { ACTION_KEYS, NUMBER_KEYS } from '../../utils/constants/keys.constant' import { formatLocaleNumber, getDecimalSeparator, getNegativeSymbol, getThousandSeparator } from '../../utils/number' import isNaN from 'lodash.isnan' +function checkIfValueIsStringAndDoesNotHaveGermanFormat(val: any): boolean { + return typeof val === 'string' && getThousandSeparator() !== '.' +} + export function isNumber(value: any): boolean { const num = parseFloat(value) return typeof num === 'number' && !isNaN(num) @@ -26,7 +30,7 @@ export function toNumber(value: any, decimalPoints = 0): number | undefined { return undefined } - if (typeof val === 'string' && getThousandSeparator() !== '.') { + if (checkIfValueIsStringAndDoesNotHaveGermanFormat(val)) { val = val.split(getThousandSeparator()).join('').split('`').join('').split("'").join('') } @@ -39,7 +43,7 @@ export function toFixedNumber(value: string, decimalPoints = 0): string { return '' } - if (typeof val === 'string' && getThousandSeparator() !== '.') { + if (checkIfValueIsStringAndDoesNotHaveGermanFormat(val)) { val = val.split(getThousandSeparator()).join('').split('`').join('').split("'").join('') }