diff --git a/.changeset/short-seals-poke.md b/.changeset/short-seals-poke.md new file mode 100644 index 0000000000..08b76c6593 --- /dev/null +++ b/.changeset/short-seals-poke.md @@ -0,0 +1,5 @@ +--- +'@baloise/ds-core': patch +--- + +**field**: fix id generation to prevent duplicate ids in a form diff --git a/.changeset/thick-lies-search.md b/.changeset/thick-lies-search.md new file mode 100644 index 0000000000..6a36d90098 --- /dev/null +++ b/.changeset/thick-lies-search.md @@ -0,0 +1,5 @@ +--- +'@baloise/ds-core': patch +--- + +**core**: Fix id assignment of bal-field children diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-desktop.png index d04e17859e..ac74e97927 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-mobile.png index bac32a62ce..2a24cd6b2a 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-desktop.png index fd75944f7a..9bb20e217b 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-mobile.png index 50fc14ef7e..d05e7cb8b4 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-selected-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-selected-desktop.png index 6ffa1d5022..a9ea978e4e 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-selected-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-selected-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-selected-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-selected-mobile.png index 7d269c4303..681097ed9d 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-selected-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-open-selected-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-value-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-value-desktop.png index 33381c5186..cec55abb57 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-value-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-value-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-value-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-value-mobile.png index 3b378289b1..b37deae9e4 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-value-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-basic-value-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-disabled-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-disabled-desktop.png index 621b498e76..6ca1e8c29e 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-disabled-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-disabled-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-disabled-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-disabled-mobile.png index a068465e4a..415da593d0 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-disabled-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-disabled-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-field-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-field-desktop.png index 37349d46ab..a864b51a7d 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-field-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-field-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-field-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-field-mobile.png index 97b9afbd0c..ab472dc3c3 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-field-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-field-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-free-solo-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-free-solo-desktop.png index e5204af2e4..2c0885fcb7 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-free-solo-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-free-solo-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-free-solo-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-free-solo-mobile.png index 06446e04bb..7fe8bad4a7 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-free-solo-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-free-solo-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-invalid-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-invalid-desktop.png index 4e2d20be50..299b0d2560 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-invalid-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-invalid-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-invalid-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-invalid-mobile.png index 612403514b..e286248412 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-invalid-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-invalid-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-desktop.png index d04e17859e..27715720eb 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-mobile.png index bac32a62ce..0c7fde5e1f 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-desktop.png index f89f79f1a1..5264351f04 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-mobile.png index 87db8b1f82..4c982a68aa 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-selected-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-selected-desktop.png index 1ec4d2a86a..98cb380634 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-selected-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-selected-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-selected-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-selected-mobile.png index 3d8c0de57c..614a96fb8d 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-selected-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-open-selected-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-value-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-value-desktop.png index cce55aed3f..6d12607dd9 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-value-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-value-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-value-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-value-mobile.png index aaf3988670..79df702d02 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-value-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-basic-value-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-disabled-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-disabled-desktop.png index e55cf600a1..d7af061977 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-disabled-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-disabled-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-disabled-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-disabled-mobile.png index 7d379ad8c3..34d2674da2 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-disabled-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-disabled-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-field-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-field-desktop.png index ada0d1f92a..5f03470b1d 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-field-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-field-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-field-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-field-mobile.png index e8b4fee87e..3c3910d1b5 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-field-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-field-mobile.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-invalid-desktop.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-invalid-desktop.png index 6827a5efd2..e02c967cdc 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-invalid-desktop.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-invalid-desktop.png differ diff --git a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-invalid-mobile.png b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-invalid-mobile.png index d39c2fcd82..be63b6d83b 100644 Binary files a/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-invalid-mobile.png and b/e2e/cypress/snapshots/base/visual/bal-select.visual.cy.ts/select-multiple-invalid-mobile.png differ diff --git a/packages/core/src/components/bal-field/bal-field.tsx b/packages/core/src/components/bal-field/bal-field.tsx index 5c405759a9..08fc751c69 100644 --- a/packages/core/src/components/bal-field/bal-field.tsx +++ b/packages/core/src/components/bal-field/bal-field.tsx @@ -184,7 +184,7 @@ export class Field implements ComponentInterface, BalMutationObserver { 'bal-field-control bal-file-upload', ]) - const ariaForm = defaultBalAriaForm + const ariaForm = { ...defaultBalAriaForm } if (label) { ariaForm.labelId = `${this.fieldId}-lbl` diff --git a/packages/core/src/components/bal-select/test/bal-select-multiple.visual.html b/packages/core/src/components/bal-select/test/bal-select-multiple.visual.html index 2fe4c9ee83..6e26706f16 100644 --- a/packages/core/src/components/bal-select/test/bal-select-multiple.visual.html +++ b/packages/core/src/components/bal-select/test/bal-select-multiple.visual.html @@ -17,27 +17,45 @@
- - Option 1 - Option 2 - Option 3 - Option 4 - Option 5 - Option 6 - Option 7 - + + Label + + + Option 1 + Option 2 + Option 3 + Option 4 + Option 5 + Option 6 + Option 7 + + + Message +
- - Option 1 - Option 2 - + + Label + + + Option 1 + Option 2 + + + Message +
- - Option 1 - Option 2 - + + Label + + + Option 1 + Option 2 + + + Message +
diff --git a/packages/core/src/utils/form.ts b/packages/core/src/utils/form.ts index c66a9b287a..81dc1b1832 100644 --- a/packages/core/src/utils/form.ts +++ b/packages/core/src/utils/form.ts @@ -31,8 +31,8 @@ export interface BalAriaFormLinking { setAriaForm(ariaForm: BalAriaForm): Promise } -export const defaultBalAriaForm: BalAriaForm = { +export const defaultBalAriaForm: BalAriaForm = Object.freeze({ controlId: undefined, labelId: undefined, messageId: undefined, -} +})