Add fixes for Take No Prisoners #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If music tracks are found, report that the virtual device is ready. dwReturn should be set to TRUE if the device is ready; FALSE otherwise.
Take No Prisoners uses MCI_FORMAT_TMSF with dwFrom set to the track's start time (0:00) and dwTo set to the track's end time, which results in info.first == info.last causing playback to stop before it even begins.
When TNP wants to restart the music, it calls MCI_PLAY with MCI_FROM and MCI_TO with both dwFrom and dwTo set to 0.
Since playback stops when the last track is reached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take No Prisoners uses MCI_STATUS_READY's dwReturn value, which wasn't being set.
The game also uses MCI_FORMAT_TMSF with dwFrom being the track's start time and dwTo being the track's end time, resulting in info.first == info.last and stopping music playback before it begins. I added a condition to set info.last to be info.first + 1 when this occurs so info.last is NON-inclusive.