Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-6143 ClientCutText/ServerCutText doesn't work #13

Open
andrews239 opened this issue Apr 2, 2024 · 0 comments
Open

RFC-6143 ClientCutText/ServerCutText doesn't work #13

andrews239 opened this issue Apr 2, 2024 · 0 comments

Comments

@andrews239
Copy link

andrews239 commented Apr 2, 2024

Expects the wrong numbers for Bell/ServerCutText in a message from a server to the client.

asyncvnc.py:

    #: Clipboard update.
    CLIPBOARD = 2

     #: Bell update.
    BELL = 3

RFC-6143:

[7.6]  Server-to-Client Messages

   The server-to-client message types defined in this document are:

                      +--------+--------------------+
                      | Number | Name               |
                      +--------+--------------------+
                      | 0      | FramebufferUpdate  |
                      | 1      | SetColorMapEntries |
                      | 2      | Bell               |
                      | 3      | ServerCutText      |
                      +--------+--------------------+

Makes the wrong padding in a clipboard update message from the client to a server.
asyncvnc.py:

        self.writer.write(b'\x06\x00' + len(data).to_bytes(4, 'big') + data)

RFC-6143:

[7.5.6]  ClientCutText
              +--------------+--------------+--------------+
              | No. of bytes | Type [Value] | Description  |
              +--------------+--------------+--------------+
              | 1            | U8 [6]       | message-type |
              | 3            |              | padding      |
              | 4            | U32          | length       |
              | length       | U8 array     | text         |
              +--------------+--------------+--------------+

With any Bell/CutText message, the server and client sides become discouraged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant