Add bucket type support #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I'm running test with this line fixed by removing the is_binary(Bucket) guard: riak-erlang-client/src/riakc_pb_socket.erl Line 945 in 68c1819 You must have a newer version of that file somewhere I'm sure. |
|
Yes, I remember changing that, but I've no idea what happened to that commit. |
|
I found an un-pushed commit :) |
| @@ -28,7 +28,9 @@ | |||
|
|
|||
| -module(riakc_obj). | |||
| -export([new/2, new/3, new/4, | |||
| type/1, | |||
There was a problem hiding this comment.
Same comment here about type in the object vs. bucket_type. Since this is client code, I would urge you to do the change here before merging. Internal code can be cleaned up, refactored easier later, but here it could be a sore point later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basho/riak#362