Fix for issue 1025 [RCS-358] #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL setup is a little kludgy way using direct RPC function call to create initial admin user, if SSL configuration is included in `rtcs` setup config argument. This also adds hand-made S3 client that uses ssl module, because all available S3 clients does not assume HTTPS access via proxy host/port (for security, of course, yes). But for local tests it is inconvenient to test HTTPS requests. Note that `https_tests` does not pass integration testing in this commit.
Closed
|
+1 772902c |
borshop
added a commit
that referenced
this pull request
Mar 21, 2016
Fix for issue 1025 [RCS-358] Reviewed-by: kuenishi
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges branches bugfix/cs1025 with current 2.1 (for full-suite testing) and replaces the hard-coded host/port destinations for the ssl object copy test with values from the configuration.
It's smaller to merge back to 2.1 than back to bugfix/cs1025, so it supersedes #1300