Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates and fixes #160

Merged
merged 15 commits into from
Feb 13, 2019
Merged

updates and fixes #160

merged 15 commits into from
Feb 13, 2019

Conversation

bmx666
Copy link
Contributor

@bmx666 bmx666 commented Aug 25, 2018

  • update compile and target SDK to API 27
  • update support and deps libraries
  • fix warn and compile error

bmx666 added 8 commits August 25, 2018 03:20
@bmx666
Update build tools
60deb9a 
* Android Gradle plugin 3.1.4
* Kotlin Gradle plugin 1.2.61
@bmx666
Update build
e30fdfe 
* compile SDK -> 27
* target SDK -> 27
* support library -> 27.1.1
@bmx666
Update deps
6c64731 
* circleimageview -> 2.2.0
* mockito-core -> 2.18.3
@bmx666
use kotlin-stdlib instead of kotlin-stdlib-jre7
1b05778
@bmx666
Update example build
b9ee672 
* compile SDK -> 27
* target SDK -> 27
* support library -> 27.1.1
@bmx666
Update example deps
0995b77 
* gson -> 2.8.5
@bmx666
fix issue with named argument
40af31c
@bmx666
fix error: get non-null Drawable
af4dc34
@bassaer
Copy link
Owner

bassaer commented Aug 25, 2018

@bmx666
Thanks 👍
let me check.

@bmx666
Copy link
Contributor Author

bmx666 commented Feb 8, 2019 •
edited
Loading

Is this project dead?

bmx666 and others added 7 commits February 10, 2019 15:26
@bmx666
update libs and tools
774bc59 
* Android Gradle Plugin -> 3.3.1
* Gradle -> 4.10.1
* Kotlin Version -> 1.3.21
* Compile SDK -> 28
* Target SDK -> 28
* Build Tools -> 28.0.3
* Gradle Bintray Plugin -> 1.8.4
* Android Maven Gradle Plugin -> 2.1
* Android Gradle Plugin JUnit5 -> 1.3.2.0
* Support Library -> 28.0.0
* Robolectric -> 4.1
* Mockito Core -> 2.24.0
* CircleImageView -> 3.0.0
* Espresso Core -> 3.0.2
@bmx666
Update test
057f60f 
* use IdlingRegistry instance instead of deprecated
  Espresso registerIdlingResources/unregisterIdlingResources
@bmx666
migrate test on Robolectric 4.1
40e6388
@bmx666
migrate on androidx, optimize imports
1d1dee8
@bmx666
Update README.md
74b4940
@bmx666
Update README.md
c17ddce
@bmx666
update version
60557b5
@bassaer
Copy link
Owner

bassaer commented Feb 12, 2019

@bmx666
Thank you for your support!

sorry for late reply.
this pull request will be merged soon.

@bmx666
Copy link
Contributor Author

bmx666 commented Feb 12, 2019

@bassaer
Thanks for response! I just back to support my old project and update all deps of this project.
Only one warn, after migrating on AndroidX many old project would not compiled without updating gradle.properties
See Migrating to AndroidX

@bassaer bassaer changed the base branch from master to develop February 13, 2019 10:22
@bassaer bassaer merged commit 07fc6ee into bassaer:develop Feb 13, 2019
@bassaer bassaer mentioned this pull request Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmx666 @bassaer