Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to choose what image attribute to use #106

Open
Florkin opened this issue Dec 16, 2022 · 2 comments · May be fixed by #107
Open

Unable to choose what image attribute to use #106

Florkin opened this issue Dec 16, 2022 · 2 comments · May be fixed by #107

Comments

@Florkin
Copy link

Florkin commented Dec 16, 2022

We work on a website where "small_images" attribute is unused. So, indexation don't find images URL, and records only placeholders.
@Florkin
Copy link
Author

Florkin commented Dec 16, 2022

I will submit a merge request soon to allow configuring this field.

@Florkin Florkin linked a pull request Dec 16, 2022 that will close this issue
Open
@Florkin
Copy link
Author

Florkin commented Dec 19, 2022 •
edited
Loading

As some website like our client's uses custom image management, I think we should be able to override or plugin getImageUrl() method. For that it must be public.
I updated the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow choosing image attribute to use on indexation Florkin/bazaarvoice-magento2-extension
1 participant
@Florkin