Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel CI: rules_dotnet failing in downstream pipeline with Bazel@HEAD #268

Closed
meteorcloudy opened this issue Dec 6, 2021 · 6 comments
Closed

Bazel CI: rules_dotnet failing in downstream pipeline with Bazel@HEAD #268

meteorcloudy opened this issue Dec 6, 2021 · 6 comments

Comments

@meteorcloudy
Copy link

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2273#a0af9fb0-30ce-4c1a-a8d2-998152915082

(02:11:36) ERROR: Traceback (most recent call last):
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/6b103ad44d5d96e1cc362a60a7eaee24/external/build_bazel_rules_apple/apple/internal/testing/ios_rules.bzl", line 62, column 61, in <toplevel>
		ios_ui_test_bundle = rule_factory.create_apple_bundling_rule(
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/6b103ad44d5d96e1cc362a60a7eaee24/external/build_bazel_rules_apple/apple/internal/rule_factory.bzl", line 904, column 55, in _create_apple_bundling_rule
		rule_attrs.append(_common_binary_linking_attrs(rule_descriptor))
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/6b103ad44d5d96e1cc362a60a7eaee24/external/build_bazel_rules_apple/apple/internal/rule_factory.bzl", line 218, column 21, in _common_binary_linking_attrs
		apple_common.objc_proto_aspect,
Error: 'apple_common' value has no field or method 'objc_proto_aspect'

Related Bazel issue: bazelbuild/bazel#13811
@meteorcloudy
Copy link
Author

rules_dotnet will be disabled in Bazel downstream until this is fixed, which means it won't get test coverage with Bazel@HEAD.

meteorcloudy added a commit to bazelbuild/continuous-integration that referenced this issue Dec 6, 2021
@meteorcloudy
Disabled and remove projects in downstream
7a34780 
Those projects are broken due to incompatible changes in Bazel and
didn't get fixed for a long time.

* Android Testing: android/testing-samples#417
* Tulsi: bazelbuild/tulsi#286
* rules_dotnet: bazel-contrib/rules_dotnet#268
* rules_haskell: tweag/rules_haskell#1650
* rules_k8s: bazelbuild/rules_k8s#668
* rules_d: removed because the project isn't maintained.
@meteorcloudy meteorcloudy mentioned this issue Dec 6, 2021
Merged
meteorcloudy added a commit to bazelbuild/continuous-integration that referenced this issue Dec 6, 2021
@meteorcloudy
Disable and remove projects in downstream
bffc7ec 
Those projects are broken due to incompatible changes in Bazel and
didn't get fixed for a long time.

* Android Testing: android/testing-samples#417
* Tulsi: bazelbuild/tulsi#286
* rules_dotnet: bazel-contrib/rules_dotnet#268
* rules_haskell: tweag/rules_haskell#1650
* rules_k8s: bazelbuild/rules_k8s#668
* rules_d: removed because the project isn't maintained.
meteorcloudy added a commit to bazelbuild/continuous-integration that referenced this issue Dec 7, 2021
@meteorcloudy
Disable and remove projects in downstream (#1287)
9b1d343 
Those projects are broken due to incompatible changes in Bazel and
didn't get fixed for a long time.

* Android Testing: android/testing-samples#417
* Tulsi: bazelbuild/tulsi#286
* rules_dotnet: bazel-contrib/rules_dotnet#268
* rules_haskell: tweag/rules_haskell#1650
* rules_k8s: bazelbuild/rules_k8s#668
* rules_d: removed because the project isn't maintained.
@meteorcloudy
Copy link
Author

/cc @tomaszstrejczek @damirdev

@purkhusid
Copy link
Collaborator

@meteorcloudy I'll take a look at this, I think it's only a matter of updating our https://github.com/rules-proto-grpc/rules_proto_grpc dependency

@purkhusid
Copy link
Collaborator

@meteorcloudy This should be fixed now

@meteorcloudy
Copy link
Author

OK, rerunning with Bazel@HEAD https://buildkite.com/bazel/bazel-at-head-plus-disabled/builds/1137

@meteorcloudy
Copy link
Author

Thanks, rules_dotnet is green with Bazel@HEAD, I'll re-enable it in the actual downstream pipeline.

meteorcloudy added a commit to bazelbuild/continuous-integration that referenced this issue Dec 9, 2021
@meteorcloudy
Re-enable rules_dotnet in downstream pipeline
c311ebb 
bazel-contrib/rules_dotnet#268 has been fixed.
@meteorcloudy meteorcloudy mentioned this issue Dec 9, 2021
Merged
meteorcloudy added a commit to bazelbuild/continuous-integration that referenced this issue Dec 9, 2021
@meteorcloudy
Re-enable rules_dotnet in downstream pipeline (#1289)
e358697 
bazel-contrib/rules_dotnet#268 has been fixed.
fmeum pushed a commit to fmeum/continuous-integration that referenced this issue Dec 10, 2023
@meteorcloudy @fmeum
Disable and remove projects in downstream (bazelbuild#1287)
07259d3 
Those projects are broken due to incompatible changes in Bazel and
didn't get fixed for a long time.

* Android Testing: android/testing-samples#417
* Tulsi: bazelbuild/tulsi#286
* rules_dotnet: bazel-contrib/rules_dotnet#268
* rules_haskell: tweag/rules_haskell#1650
* rules_k8s: bazelbuild/rules_k8s#668
* rules_d: removed because the project isn't maintained.
fmeum pushed a commit to fmeum/continuous-integration that referenced this issue Dec 10, 2023
@meteorcloudy @fmeum
Re-enable rules_dotnet in downstream pipeline (bazelbuild#1289)
efb965b 
bazel-contrib/rules_dotnet#268 has been fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meteorcloudy @purkhusid