-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for resources in javadoc jars and make variable substitution in javadoc arguments #1238
Add support for resources in javadoc jars and make variable substitution in javadoc arguments #1238
Conversation
…ble substitution in javadoc arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small nits, and then I'll merge. Thank you for re-opening!
@shs96c Made the suggested changes, this is ready for another review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for making the changes!
Note: This is a dupe of #1182 . I had to reopen the PR from a different GH org.
There's two use cases I'm trying to account for here.
LICENSE
file.--define
variable to the javadoc generator so that themaven_version
variable I have set will appear in the<title>
of the generated html. rules_jvm_external already supports the same type of substitution on thecoordinates
attribute.